Repository navigation
feat(appjail): watch updated jails stay up, as podman's containers are - #140
Merged
Merged
Conversation
An AppJail update ended when director said the jail was up, and an app that died on its new image still read as a clean update: appjail keeps a jail up after its app exits (persist, which its start needs), with nothing running inside, and appjail status says running. Each updated jail is now watched for 30 seconds, like podman's containers: it fails if it goes down, if it is started again (its jid changes), or if nothing runs inside it any more, and at the end if its app keeps crashing (s6 in its log, nothing on its port). Failures are [error] lines, which the page reads as a failed update -- and Roll back is there for it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An AppJail update ended when director said the jail was up, and an app that died on its new image still read as a clean update: appjail keeps a jail up after its app exits (persist, which its start needs), with nothing running inside, and appjail status says running. Each updated jail is now watched for 30 seconds, like podman's containers: it fails if it goes down, if it is started again (its jid changes), or if nothing runs inside it any more, and at the end if its app keeps crashing (s6 in its log, nothing on its port). Failures are [error] lines, which the page reads as a failed update -- and Roll back is there for it now.