Repository navigation
feat(appjail): roll back, pin and change one service's version - #139
Merged
Merged
Conversation
AppJail stacks could update one service but not undo it: rollback, a
service's own Version... and pins all sat behind PinServices, false for
AppJail because director never reads the compose. Now the director follows
the compose for the services a pin or a version touches: a service naming
its own from: gets the image there, one built from the Makejail gets the
tag argument its OPTION from=<repo>:${tag} reads, digest included
('2.0@sha256:...' builds that digest). A director project with no compose
is written directly, and so is Version... on a service the compose names
differently (bundles call a sidecar authelia-redis where the compose says
redis). The update check reads a director-only service's image
from the director, so a pinned one says pinned.
Addresses need nothing: a rebuilt jail keeps its address on its own (DHCP:
its epair keeps its name, so its generated MAC and lease; virtualnet: its
reservation). KeepsAddresses says so, and fjord's pinning skips it.
Saving a stack no longer rewrites an unchanged Makejail: director rebuilds
every service built from it when the file is newer than its last run, so
rolling back one sidecar restarted the app.
test/ui/appjail-update now rolls sync back from its row and checks the jail
runs the image it had, pinned, while web keeps its jid throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppJail stacks could update one service but not undo it: rollback, a service's own Version... and pins all sat behind PinServices, false for AppJail because director never reads the compose. Now the director follows the compose for the services a pin or a version touches: a service naming its own from: gets the image there, one built from the Makejail gets the tag argument its OPTION from=:${tag} reads, digest included ('2.0@sha256:...' builds that digest). A director project with no compose is written directly, and so is Version... on a service the compose names differently (bundles call a sidecar authelia-redis where the compose says redis). The update check reads a director-only service's image from the director, so a pinned one says pinned.
Addresses need nothing: a rebuilt jail keeps its address on its own (DHCP: its epair keeps its name, so its generated MAC and lease; virtualnet: its reservation). KeepsAddresses says so, and fjord's pinning skips it.
Saving a stack no longer rewrites an unchanged Makejail: director rebuilds every service built from it when the file is newer than its last run, so rolling back one sidecar restarted the app.
test/ui/appjail-update now rolls sync back from its row and checks the jail runs the image it had, pinned, while web keeps its jid throughout.