Skip to content

tests: stop post-push housekeeping racing test_pickup_fence's tearDown #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d6g8k5htny-coder merged 2 commits into from
Oct 21, 2026
Merged

tests: stop post-push housekeeping racing test_pickup_fence's tearDown #481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f185156
tests: stop post-push housekeeping racing test_pickup_fence's tearDown
claude Oct 21, 2026
fed4743
Prepare PR #481 with the actual #477 landing, preserving the reviewed…
d6g8k5htny-coder Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_pickup_fence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ def git(*args, cwd, check=True):
return r


def no_housekeeping(repo):
"""Turn off automatic gc and maintenance in ``repo``. They can run detached after a push,
fetch or commit and still be writing into ``objects/pack`` while tearDown removes the tree.
The setting goes in each repository's own config, because a local ``receive-pack`` does not
see the pushing side's ``-c`` or ``GIT_CONFIG_*`` settings."""
for key, value in (('gc.auto', '0'), ('maintenance.auto', 'false'), ('receive.autogc', 'false')):
git('config', key, value, cwd=repo)


class PickupFenceTest(unittest.TestCase):
"""Worker A holds a stale view of ``work``; worker B has pushed a newer commit."""

Expand All @@ -42,8 +51,10 @@ def setUp(self):
root = self.tmp.name
self.remote = os.path.join(root, 'remote.git')
git('init', '--bare', '-q', '-b', 'main', self.remote, cwd=root)
no_housekeeping(self.remote)
seed = os.path.join(root, 'seed')
git('clone', '-q', self.remote, seed, cwd=root)
no_housekeeping(seed)
with open(os.path.join(seed, 'f.txt'), 'w') as f:
f.write('base\n')
git('add', 'f.txt', cwd=seed)
Expand All @@ -53,6 +64,7 @@ def setUp(self):
self.b = os.path.join(root, 'b')
for d in (self.a, self.b):
git('clone', '-q', '-b', 'work', self.remote, d, cwd=root)
no_housekeeping(d)
self.old_head = git('rev-parse', 'HEAD', cwd=self.a).stdout.strip()
# B advances the branch; A does not fetch.
with open(os.path.join(self.b, 'f.txt'), 'a') as f:
Expand Down
Loading