Repository navigation
Keep Library searches bookmarkable and recoverable - #235
Conversation
Implemented by OpenAI/Codex under Dylan Roy's delegated UI authority. Source pins, scientific records and prior navigation helper unchanged.
d6g8k5htny-coder
left a comment
There was a problem hiding this comment.
Dylan Roy — delegated AI review. Actual performer: OpenAI reviewer agent review_library_search_design, nonauthor of this change, with prior design and source exposure. Same-provider review; organizational-independence credit 0. Dylan's personal reading remains PENDING.
Source-bound COMMENT for head 1dfd7f7, tree b03047c752ecf429b72ad59672d7e0ad733392f5, base 9784018. I read the published commit and reconciled it with the exact local commit/tree.
No blocking source defect found. The bounded successor comparison against previously reviewed tree 225f69780c9df8d1e1601b501589c21069871560 changes only explanatory copy, the existing test's name, and a new malformed-UTF-8 query test. The URL/filter implementation, rendered controls, source pins, inventory, CSS, brand tokens, and prior fragment helper retain their reviewed scope. Both minor findings are resolved: the text no longer implies that a mutable search URL freezes a snapshot, and literal ?q=%E0%A4%A is exercised through the actual app import.
Fresh successor verification: the new malformed-UTF-8 test passes (1/1); git diff --check passes; app.js, workspace.html and reader-navigation integration are unchanged from the prior reviewed tree. The prior independent run passed reader/query/navigation/frontend suites (93 executions, including duplicate imported suites), the fixture-backed app suite (4/4), and reader-link checks (3/3). Those unchanged scopes are reused rather than claimed as newly rerun. URL updates preserve fragments, unrelated address parameters and history.state; explicit links include only the three filters; restoration, pagination reset, refusal handling and keyboard-focus behavior passed the recorded DOM harness checks.
Disposition: suitable to continue as a draft PR. Changed-code real-browser desktop/mobile, light/dark, keyboard and overflow validation remains OPEN. Current required hosted checks and integration reconciliation remain necessary. This COMMENT supplies no browser pass, merge-readiness approval, mathematical acceptance or organizational-independence evidence. Scientific effect NONE.
|
Exact-head update: all seven hosted checks passed for 1dfd7f7. Required verify binds tested merge fc1e68b at run37019912191/attempt1, receipt SHA256 d7832b7174c4ce56370de0ef175028a2953c0e915b032441133df19aa46f94a6. Separate successor review5392992607 resolves both minor findings; final local frontend83/83. Draft remains because actual changed-browser QA is still absent. The coordinator now assigns a bounded test-capability extension on this same owned branch: a loopback-only GitHub Actions Chromium smoke test for this Library flow, with screenshots returned solely as normal repository CI artifacts. Intended additional paths: tools/public_shop_browser_check.py, tests/browser-requirements.txt, and the existing public-shop workflow plus narrow harness contract tests/documentation if useful. No public preview/hosting, new secrets, permission expansion, or production merge. The existing CUA loopback restriction remains blocked; this is repository test execution under the user’s UI-quality delegation, not a claim that the blocked browser was unblocked. Independent source review and screenshot inspection are still required. |
Separate sandboxed Chromium job; loopback docs only, no public preview. Four viewport/theme flows and specific inventory-503 refusal evidence. OpenAI/Codex implementation under Dylan Roy delegated UI authority.
|
Draft successor5b55ce0f2f95ada7e9851d9b15afc9509cc92f25 / tree69dca35ae4a1639f5465d6224f8b9a28f348c4dd adds the independently source-reviewed CI browser capability only. Existing site implementation and original public-shop job are unchanged. Three stdlib contract tests were red before capability code and pass in ordinary/optimized modes; full local stdlib suite297 tests/mode passed with one existing skip. The negative browser control now requires one actual CORS-visible inventory503 and its exact refusal message, rather than allowing any loading error to count. No browser success is presumed until this successor's job/artifact is inspected. Earlier green hosted checks remain evidence for the earlier1dfd7f7 only. |
Keep Chromium sandbox and host AppArmor policy enabled. Record packaged browser and image identities; preserve failed initial run.
|
Preserved failed browser attempt37021615867 / artifact11232871777 (SHA25667bb4eb847933ac2499a90dbd254680fbe29334c612e7b6ab19f03418553b41c). The downloaded shell could not obtain an Ubuntu24.04 sandbox, so no page or UI assertion ran. This is zero UI coverage, not a failed product assertion. Successor21d015acbe545fd584cf611d34bc6905b635c692 makes the peer-reviewed, documented correction: use the runner’s already-installed Chrome stable channel with chromium_sandbox=true, and pin only the new job to ubuntu-24.04. It records actual executable SHA256/version/image identity. No sandbox/AppArmor/permission change or insecure fallback is introduced. See Chromium’s existing stable-Chrome policy and the exact observed runner inventory. The original public-shop job remains unchanged. Browser result and screenshots remain pending the new run. |
Expected red: screenshot review found visible Show-more for complete results. Also verify that restored pagination still expands the real catalog.
Rendered regression failed in all five browser cases before this rule. Keep Show-more available only when verified results remain undisplayed.
|
Visual review found a real Library pagination defect even though the first five browser scenarios passed: CSS display:inline-block overrode the HTML hidden attribute. Live cloud Chrome independently confirmed hidden=true/display=inline-block/45px rendered height for a1/1result. The source test-only successor e4719f5 added rendered visibility checks; run37022810043 failed in all five cases with the intended The next successor applies only |
d6g8k5htny-coder
left a comment
There was a problem hiding this comment.
Dylan Roy — delegated AI review. Actual performer: OpenAI reviewer agent review_library_search_design, nonauthor, with prior design and source exposure. Same-provider review; organizational-independence credit 0. Dylan's personal reading remains PENDING.
Final source-bound engineering COMMENT for head 31c8588, tree b639148b808c1734593bb3ddb01a52eb446bca74, base 9784018. Current PR readback identifies tested merge 3f97b70; its browser report records the same reviewed tree and exact PR head.
My pagination finding is resolved. I inspected all five final PNGs: 1200×900 and 390×844 in light/dark, plus inventory refusal. “Show 50 more” is now absent for exhausted/refused results. Text, source identities, controls, wrapping and focus outlines remain legible in the inspected Library captures. The scoped CSS change is only #more[hidden]{display:none}. The browser checks also require pagination to be visible after reset and exercise the real 50-to-100-row click, preventing a blanket-hide false positive. The unavailable search link's active-looking styling remains a known nonblocking presentation limitation; its no-href behavior is correct.
Verified evidence: public-shop run 37023154960, attempt 1, artifact 11233128816 (public-shop-browser-37023154960). GitHub artifact metadata and local ZIP both match SHA-256 02f63ba68e238b0640dc1dbcde568579cb87ae58a584a33a6e399ad12d7d124b. Extracted archive bytes, all five screenshot hashes, report commit/tree and commit.txt were checked. Report: 5/5 cases passed with no page errors, sandbox-enabled packaged Chrome 154.0.8037.57, Playwright 1.62.0, ubuntu24 image 20260927.320.1. The original no-sandbox-available failure remains zero UI coverage. The separate red pagination artifact records actual visibility failures in all five cases; those failures are preserved rather than relabeled as passes.
Fresh local checks at this head: frontend/brand suite 28/28, browser contract suite 3/3, and git diff --check pass. Protected config/status/catalog bytes, the prior fragment helper, brand CSS and tokens remain unchanged from base. Earlier source and URL-state review remains applicable to its unchanged implementation. Current public-shop workflow readback reports success.
Disposition: no remaining blocking finding in my reviewed engineering scope; ready for the designated integration owner to reconcile current head/base, ownership, reviews and all required checks before merging. This closes my browser/visual gate for the stated head and viewport scope. It does not certify physical devices, other browsers, full accessibility, deployed Pages, mathematical acceptance or organizational independence. Scientific effect NONE.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Integration custody pickup under the coordinator’s scoped handoff and Dylan’s routine-engineering delegation: the implementation worker now owns this PR’s normal merge and landed verification, after independent nonauthor review5393316085. This supersedes the initial plan to return merge execution to the parent; it does not recast the author as a nonauthor reviewer. No competing UI writer was found in current main229 readback. Current head31c8588/base97840180/tested merge3f97b703 retain the reviewed treeb639148b. All eight hosted checks passed, including actual browser evidence; automatic repository Codex review completed at15:04:04Z on31c8588 with no new review submission/findings. No inline review threads are unresolved. I will use the ordinary protected merge with the exact head guard, preserve every earlier failure/receipt, then verify landed checks and Pages separately. No scientific acceptance or permission/protection change. |
|
The protected merge correctly refused with405 because main advanced via #232 at15:00:24 to9677f2849994f794f3956beec86e6ba7158c0306. The PR API's base.sha still showed97840180, but a direct main-branch read and the new synthetic merge expose the newer base. This is not a missing human approval and no protection was bypassed. I read the complete four-file #232 delta: P15 split, reader-route note, histogram protocol, and a narrow public-mathematics catalog row split/additions. They are disjoint from our11changed paths and must be preserved. I own a source-preserving refresh of this branch onto current main, followed by a bounded nonauthor unchanged-UI/source comparison and fresh hosted/browser checks. Prior green runs remain bound to their prior tested commits. |
Preserve all four files from main#232 at9677f284 unchanged. All reviewed Library UI and browser-check source blobs remain unchanged. Fresh hosted integration and browser checks required at this new head.
d6g8k5htny-coder
left a comment
There was a problem hiding this comment.
Dylan Roy — delegated AI review. Actual performer: OpenAI reviewer agent review_library_search_design, nonauthor, with prior design/source exposure. Same-provider review; organizational-independence credit 0. Dylan's personal reading remains PENDING.
Bounded successor COMMENT for refreshed head 4291ab7, tree b3c882df2dad98061ab144702c5ae6e40c18b4ab. Verified actual parents are reviewed UI head 31c8588 and landed main 9677f28. The refreshed tree exactly equals git merge-tree for those parents.
All 11 UI, test, dependency and workflow blobs are byte-identical to the previously reviewed UI head. The only delta from that head is the four landed documents: docs/P15_SPLIT.md, docs/PUBLIC_MATHEMATICS.md, docs/READER_SPLIT.md and docs/SIMULATION_PROTOCOL.md. Each is byte-identical to landed main 9677f28; the diff from that main contains exactly the 11 reviewed UI paths, with no unexpected path. I read the complete four-document integration delta for dependency/navigation impact. This comparison preserves the landed documents and does not add a mathematical acceptance review of their content.
Fresh successor verification: reader-link checks 3/3 and git diff --check pass. No refresh finding remains in this engineering scope. The earlier source/browser review #235 (review) and artifact 11233128816 remain evidence for the exact unchanged UI/source slice. They are prior executions at their recorded commit, not new runs attributed to this refreshed head.
The designated integration custodian retains normal merge and landed verification. Fresh hosted checks/browser evidence must bind to the actual refreshed test commit, and current head/base, ownership and unresolved findings must be reconciled before merge. No protection bypass, scientific acceptance or organizational-independence credit is supplied by this COMMENT. Scientific effect NONE.
|
Completion receipt — PR235 merged normally at1c8b4650d991c47fc049aee749c6a4ff99676577, treeb3c882df2dad98061ab144702c5ae6e40c18b4ab. Pages37025754032, landed public-shop/browser37025757158, and workspace/formal37025757185 all passed. Landed browser artifact11234953410 reports5/5scenarios and is byte-verified (ZIP SHA256819e2c4b68090ee913517ccc166006eacadeb072588629428da9dfc9b4a46e06). Landed formal artifact11234692683 and receipt are verified separately; receipt SHA2564aa15f5623a0e53514c3a47408fa1a8cf1eaaf131750a359160f44b97c11793b. Production cloud Chrome verified the combined search restores one exact proof after reload, keyboard Clear restores50rows and search focus, Show-more expands50→100, Back/Forward restoresSIDE24↔EC-014 and the corresponding sections, and exhausted pagination is display:none. The original CUA loopback block, initial CI sandbox failure, all five rendered red pagination failures, and the protected-merge refusal after main advanced are retained as actual history. Required rules, scientific records and source pins were not weakened or promoted; the four landed #232 documents remain exact. A single canonical36-payload local archival delivery was built and verified with the existing research_delivery.py:2,618,861bytes, SHA256999cc9c3f9c50a241e1e2d7e51fe5bbbf5cc340ada3e98f42aaafd4e9421d3b0. Its original execution ZIPs remain unmodified. The local bundle is held by the coordinator; this does not claim a Drive upload or sharing change. Implementation and integration claim5954437949 is released. Future architecture work is separate. Actual OpenAI/Codex author and coordinated nonauthor review; organizational independence0; scientific effectNONE. |
Change and purpose
Library searches can now be bookmarked and restored instead of resetting after refresh. Search, repository and path filters round-trip in the URL; Link to this search targets the Library, and Clear filters restores the first 50 rows. The existing misleading “Show 50 more” control is now hidden when all results are shown or the source is unavailable.
Bounded presentation/engineering scope, coordinated in main#229 pickup. Live cloud Chrome reproduced both original defects. Source records and scientific scope remain unchanged.
Design decision
Compared browser-only saved state, a separate search page, and URL state in the existing Library. Selected the last: small, portable, no new source inventory or service. A separate nonauthor reviewed the design before implementation.
Typing preserves the current fragment, unrelated parameters and history.state without per-keystroke history entries. The explicit link includes only allowlisted filters. Back/Forward restoration does not write new history or steal focus. History exceptions preserve search/link usability. Controls remain unavailable until hash verification succeeds. A search URL does not freeze future catalog updates.
Current disposition
Merged and deployed. Pages37025754032, landed public-shop/browser37025757158, and landed workspace/formal37025757185 all passed at the actual landed commit. At15:19UTC, production cloud Chrome verified the combined proof-search bookmark, reload, keyboard clear/focus, pagination50→100, and Back/Forward query/section restoration. Exhausted pagination is truly display:none.
4291ab7fb7d3f7f818ab000eb0c73769ff333cb1b3c882df2dad98061ab144702c5ae6e40c18b4ab9677f2849994f794f3956beec86e6ba7158c0306653a55a774fc69db72f04dbb9a49b0b0312e7641, same tree1c8b4650d991c47fc049aee749c6a4ff99676577, preserving the reviewed tree. All three landed runs and the live Pages checks passed. The implementation/integration claim is released; source branch and original failure evidence are retainedVerification and evidence
After main#232 landed, the first protected merge attempt refused stale integration checks. Refresh4291ab7 preserves all11 reviewed UI/test/workflow blobs and all4 landed #232 document blobs. Fresh required run37025054585 and browser run37025054116 pass at tested merge653a55a7; all8check-runs pass. Browser artifact11234212713 has ZIP SHA256
4d1586dfbe549a92efee2eff511ea111d9b5903678c73d8d4717f429e1842115and5/5cases. Required receipt SHA256 is85113a0a566321a2bed3f4d9c3bd0d8e185de0416638307141e1a709e0a8aac3. The unchanged UI review and inspected screenshot coverage retain their scope; the following earlier records are preserved under their own commits.0f446cb060d9f012b5aa13546999641d623a8d3567496e4f4828f654192d7a1402f63ba68e238b0640dc1dbcde568579cb87ae58a584a33a6e399ad12d7d124b; all five screenshots inspected by author and nonauthor, individual hashes verifiedThe new optional browser job appends to the existing public-shop workflow without changing its original job or permissions. It serves only docs over loopback, uses pinned Playwright tooling and the runner's packaged Chrome with sandbox enabled, records actual browser/image/commit identities, and retains failure artifacts. No hosting, secret, AppArmor or permission changes.
Preserved failures: initial CUA loopback block; initial Python source-fetch tunnel403; shallow-export source-identity refusal followed by exact historical-fixture reproduction; first CI downloaded-shell sandbox failure with zero UI coverage; and true rendered-pagination red run37022810043, five expected visible-when-hidden failures before the one-rule CSS fix. Earlier runs are not rebound to this head.
Boundaries
Headless Chrome154 desktop/mobile-sized viewports, not physical touch devices, all browsers or full accessibility certification. Branch CI does not attest landed Pages. The optional unavailable-link styling suggestion remains nonblocking; the unavailable link has no href and is not keyboard-activatable.
Config/status/catalog/proof bytes, scientific records, #234 fragment helper and brand tokens are unchanged. CSS change is only
#more[hidden]{display:none}. Existing #228/#232 and Math#163 scopes remain separate.Dylan Roy — delegated AI work/review. Actual author and coordinated nonauthor reviewer are OpenAI agents; prior design/source exposure disclosed, organizational-independence credit0, Dylan's personal reading pending. Scientific effect NONE.