Skip to content

Legacy trigger parser: reject unsupported plus repetition #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
d6g8k5htny-coder wants to merge 1 commit into from
Closed

Legacy trigger parser: reject unsupported plus repetition #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion tests/test_legacy_workflow_triggers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def trigger_paths(text):
raise ValueError('unsupported path-list syntax')
pattern = match[1]
plain = pattern[:-3] if pattern.endswith('/**') else pattern
if any(c in plain for c in '*?[]{}!'):
if any(c in plain for c in '*?[]{}!+'):
raise ValueError('unsupported path pattern')
found.append(pattern)
if not found or len(found) != len(set(found)):
Expand Down Expand Up @@ -134,5 +134,29 @@ def test_limited_path_reader_rejects_unsupported_syntax(self):
trigger_paths(template % rows)


def test_plus_repetition_operator_is_not_treated_as_literal(self):
template = "'on':\n pull_request:\n paths:\n - '%s'\n workflow_dispatch:\n"
for pattern in ('tools+.py', 'tools+/helper.py',
'tools/legacy+/__init__.py', 'tools+/**'):
with self.subTest(pattern=pattern), self.assertRaises(ValueError):
trigger_paths(template % pattern)

def test_supported_literal_and_subtree_patterns_keep_their_meaning(self):
patterns = ['tools.py', 'tools/**', '.github/workflows/local-pairing.yml',
'checks/a-b_2.3.py']
text = "'on':\n pull_request:\n paths:\n"
text += ''.join(" - '%s'\n" % pattern for pattern in patterns)
text += ' workflow_dispatch:\n'
self.assertEqual(trigger_paths(text), patterns)
for path in ('tools.py', 'tools/__init__.py', 'tools/nested/file.py',
'.github/workflows/local-pairing.yml', 'checks/a-b_2.3.py'):
with self.subTest(included=path):
self.assertTrue(covered(patterns, path))
for path in ('tools_extra/file.py', 'other/tools.py',
'other/tools/file.py', 'checks/a-b_2x3.py'):
with self.subTest(excluded=path):
self.assertFalse(covered(patterns, path))


if __name__ == '__main__':
unittest.main()
Loading