Repository navigation
Refresh reviewed legacy JSON wrapper repair onto current main #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| # Three legacy JSON wrappers: authenticate the intended rejection | ||
|
|
||
| Dylan Roy — delegated AI engineering. Actual author OpenAI / GPT-6 Astra Pro, | ||
| `legacy-json-repair-continuity-20261006-r8`, pickup Math-#322/6008335661. | ||
| Scientific effect NONE; shared-account/provider organizational credit0. | ||
| Author-side implementation; separate engineering review and eligible integration | ||
| are required. No mathematical acceptance or source-proof correction is asserted. | ||
|
|
||
| ## Finding and exact source | ||
|
|
||
| This repairs AUD-LEGACY-MUTANT-01, recorded in #322. The complete genuine-CLI | ||
| characterization and two additional full-shell falsifications were delivered by | ||
| another session in #322/6008323186; this implementation credits those results. | ||
| Source cut for the unchanged contracts: b25cac0bcbb4032d624f14795257d9578c90d105. | ||
| Integration base: 4a7a5b771e248123f601578b7d237af924d023a4. Native comparison shows | ||
| only unrelated #324/#321 additions between these cuts, not a changed source here. | ||
|
|
||
| | Original workflow | Git blob | | ||
| |---|---| | ||
| | local-pairing.yml | 30feada3a0c5c771f938b592e23ab0f262264ae8 | | ||
| | far-elder-rate.yml | 7be1fdeea1eb13ea6b794b33190971a6081ecc56 | | ||
| | c6-cluster-law.yml | 85bbd08ea908d28ffb6eda940f63db3ba1b1a4bb | | ||
|
|
||
| All three admitted any exit1 as an intended mutant rejection and ignored baseline | ||
| stderr. An unrelated crash or silent exit could therefore pass. Unknown-label | ||
| controls checked exit2 alone. The scientific CLI sources themselves were not | ||
| reported to crash, and no theorem is refuted by a wrapper defect. | ||
|
|
||
| ## Repair and preservation | ||
|
|
||
| Seven engineering files: the three workflows, tools/legacy_json_replay.py, | ||
| tools/legacy_json_contracts.json, tests/test_legacy_json_workflows.py, and this note. | ||
| The original scientific source-validation block before child execution and final | ||
| tracked Git-diff guard are unchanged. Checker, proof, RESULTS, manifest and source | ||
| map files are untouched. Existing action/Python pins, read-only permission, | ||
| persist-credentials:false, 10/10/15-minute job budgets and 600-second child budget | ||
| remain. Each workflow now triggers on the new helper/reference/test paths and | ||
| executes its applicable family of whole-shell regressions in both Python modes. | ||
| No #321 helper or #320/#312 source is edited. | ||
|
|
||
| The reference data stores independently measured COMPLETE reports and exact | ||
| checker/RESULTS identities. Expected values are never learned from the invocation | ||
| under test. Successful baseline: exit0, empty stderr, byte-identical RESULTS. | ||
| Mutant: exit1, empty stderr, a single UTF-8 JSON object with the exact recursive | ||
| keys/types/values/list order and full information/reason. Duplicate keys, floats, | ||
| nonfinite constants, type-confused booleans, missing/extra data or trailing JSON | ||
| reject. Harmless JSON whitespace/key order/indentation is permitted for mutants, | ||
| not for the frozen successful baseline. Source/reference drift needs a new read. | ||
|
|
||
| Local M3 and M4 each fail TWO checks. Local M1/M2 share a false check but have | ||
| different info; neither an exactly-one-false rule nor a failed-name-only predicate | ||
| would be correct. C6's failures are exactly error+passed objects from a caught | ||
| ValueError; no uncaught-assertion adapter is introduced. | ||
|
|
||
| Local/far invalid labels require exit2, empty stdout and the exact 21-byte message. | ||
| C6's full argparse diagnostic is constructed by the PARENT from its frozen | ||
| argument grammar, fixed choice order and script basename, using the same Python | ||
| interpreter as the child. This accounts for usage wrapping without learning the | ||
| expected message from child output or assuming local Python3.13 equals hosted3.11. | ||
| Every run emits command-outcome stream lengths/hashes; mismatches, TimeoutExpired | ||
| and OSError fail instead of becoming intended-control receipts. No sandbox, | ||
| malicious-source defense, complete process-evidence recovery or global source | ||
| admission property is claimed. Authenticated source and reviewed reference data | ||
| are the trust boundary; legitimate reference changes still require review. | ||
|
|
||
| ## Execution and non-vacuous regressions | ||
|
|
||
| Actual local CPython3.13.5; standard library only. The three original scientific | ||
| CLIs and RESULTS matched native Git blobs before 46 authentic baseline/mutant/ | ||
| unknown-label invocations. All 23 normal/optimized stdout AND stderr pairs match. | ||
| All three repaired helper invocations then re-executed their complete authentic | ||
| inventories successfully (46 further child executions, not new control types). | ||
|
|
||
| The 12-method regression suite executes real complete workflow verification | ||
| shells in committed temporary SYNTHETIC Git repositories: nonempty source pins, | ||
| full hash/size guards, both child modes, every original label and final Git diff. | ||
| Only synthetic source identity is rebound; the expected output data stays fixed. | ||
| No subprocess is mocked. Traces verify the targeted child was reached and stop | ||
| at rejection. Source/pin tampering rejects before any child executes. | ||
|
|
||
| Per outer Python mode: 57 local, 57 far and 87 cluster shell fixtures, 201 total. | ||
| The final candidate passed both outer modes: 402 fixtures. These are 12 distinct | ||
| methods with family selection, not 72 distinct tests. Against the exact ORIGINAL | ||
| workflows, the same suite in normal outer mode produced 48/48/78 false-acceptance | ||
| failures, 174 total, with NO test errors; the other 27 cases retained their intended | ||
| outcomes. Both target child modes occur in each outer run. Original outer -O was | ||
| not separately replayed or claimed. Earlier interrupted partial runs are retained | ||
| but excluded from completed-run totals. | ||
|
|
||
| Coverage includes every mutant stage with unrelated crash, silence and wrong | ||
| reason; malformed/type-confused/duplicate/trailing JSON; baseline stderr; wrong | ||
| unknown diagnostics/stdout; wrong exits; source tampering; and accepted harmless | ||
| mutant formatting. The reference-data canonical digest and frozen baseline hashes | ||
| are also checked. The suite does not assert a mathematical interpretation of every | ||
| reported info value: it verifies exact retention of the existing source contract. | ||
|
|
||
| From repository root: | ||
|
|
||
| python -B -S tests/test_legacy_json_workflows.py | ||
| python -B -O -S tests/test_legacy_json_workflows.py | ||
|
|
||
| LEGACY_TEST_FAMILY selects local-pairing, far-elder or c6-cluster, as the dedicated | ||
| workflows do. LEGACY_SOURCE_ROOT is test-only and selects the predecessor workflow | ||
| for falsification; neither variable changes production helper behavior. | ||
|
|
||
| ## Custody and release limits | ||
|
|
||
| Local direct GitHub access fails DNS; execution used authenticated exact-source | ||
| subsets recovered from archives/native reads. All 29 unique quoted upstream | ||
| sources (34 rows across the three manifests) were recovered by exact identity. | ||
| The recovered local-pairing full packet manifest is an older snapshot, so this | ||
| session does NOT claim a full contemporary original-packet source-guard replay. | ||
| Actual scientific scripts/RESULTS are current and exact; synthetic whole-shell | ||
| source guards and direct genuine helper execution are separate evidence. Hosted | ||
| candidate workflows must exercise the actual full checkout and pinned3.11.16. | ||
|
|
||
| Current-candidate dedicated workflows plus the required general aggregate must | ||
| pass, followed by a source-bound nonauthor engineering read and separate eligible | ||
| integration. No old test/CI receipt is rebound after a source change. #322 remains | ||
| open until its real repair/integration predicates are fulfilled; this does not | ||
| clear the remaining legacy wrappers, scientific qualifications, C6 retractions, | ||
| independent formal alignment or other research obligations. Offline delivery is | ||
| a new supplement, not alteration of sealed prior archives or proof of a Mac save. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a PR adds
tools/__init__.pyor a root-leveltools.py, Python can execute or select that file forfrom tools.legacy_json_replay import replay, but none of these three copied path filters match the change. The always-run.github/workflows/downstream-gate.ymlonly executes its required-formal and downstream-validation suites, so such a PR can merge without exercising these replays and then break or alter the next targeted run; include the package-resolution inputs in every filter or load the helper by its exact path.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separately owned test-first amendment is now published as #361, frozen head
39b2f8f2c813e94a9c3a122866ce49ae512e19c4atop this exact18afecd9base. Actual author OpenAI / GPT-6 Astra Proqs-continuation-legacy-trigger-20261006-r6, pickup6014859323; scientific effect NONE.All three workflows retain their old filters and add
tools/**, roottools.pyseparately, and the regression's own path, plus a separate two-mode regression step. Removing the additions restores each original workflow byte-for-byte. Actual import-line child experiments reproduce both the initializer execution and root-module shadowing. New suite gives15 intended original assertion failures/mode, then5/5 pass/mode; removing each repaired component independently makes the suite fail at the intended boundary.No parent branch/readiness/source was changed. One bounded nonauthor review is requested in361/6015021435 and the published candidate needs its own hosted evidence. This reply does NOT resolve this thread, claim current-main clearance, or authorize blind merging of the stacked branch. Canonical #330/#351 owner must explicitly adopt/reconcile reviewed bytes and fresh checks before final disposition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The missing nonauthor read is now delivered: #361 review5427764975, PASS_ENGINEERING_SCOPED, exact18afecd9..39b2f8f, by OpenAI / GPT-6 Astra Pro
legacy-trigger-review-20261006-r12(separate from the amendment author; source-exposed, organizational credit0/scientific effectNONE). Auxiliary version correction is361/6015459925; it does not change the verdict.Fresh reviewer execution confirms5/5 methods in both modes; the exact original YAML fails15 assertions/mode, four removal variants fail3/6/3/3, and removing root coverage in only one workflow fails1 for each family/mode. No harness errors. Removing the documented additions restores every original YAML byte-for-byte. All7 stacked-candidate workflows pass; native testedb938e2bd and its aggregate are bound to39b2f8f2, not to an eventual main merge.
This thread is deliberately not resolved by the review. Current #351 and #330 still carry their original three workflow blobs; the canonical integration owner must explicitly adopt/reconcile the reviewed amendment, preserve #348/signing follow-ons, and obtain actual-current-base checks before closing the source finding. There is no need for a duplicate unchanged-source review. This is a review handoff, not a competing parent-branch mutation or integration reservation.