Repository navigation
refactor(silentpayments, tests): use native deserialization - #203
Merged
Merged
Conversation
Instead of reading the json fields as String and parsing them inside the tests, just use the built-in deserialize trait for many of the rust-bitcoin structs. The only exception is Witness, which requires a custom deserializer since by default this expects a byte array instead of a string.
cygnet3
force-pushed
the
refactor/use-native-structs-tests
branch
from
November 10, 2026 15:36
147ac46 to
5a446dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reading the json fields as String, converting to hex string and parsing them inside the tests, just use the built-in deserialize trait for many of the rust-bitcoin structs.
The only exception is Witness, which requires a custom deserializer since by default this expects a byte array instead of a string.