Skip to content

refactor(silentpayments, tests): use native deserialization - #203

Merged
cygnet3 merged 1 commit into
masterfrom
refactor/use-native-structs-tests
Nov 11, 2026
Merged

cygnet3 merged 1 commit into
masterfrom
refactor/use-native-structs-tests

Conversation

@cygnet3

@cygnet3 cygnet3 commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Instead of reading the json fields as String, converting to hex string and parsing them inside the tests, just use the built-in deserialize trait for many of the rust-bitcoin structs.

The only exception is Witness, which requires a custom deserializer since by default this expects a byte array instead of a string.

Instead of reading the json fields as String and parsing them inside the
tests, just use the built-in deserialize trait for many of the
rust-bitcoin structs.

The only exception is Witness, which requires a custom deserializer
since by default this expects a byte array instead of a string.
@cygnet3
cygnet3 force-pushed the refactor/use-native-structs-tests branch from 147ac46 to 5a446dd Compare November 10, 2026 15:36
@cygnet3
cygnet3 merged commit afae84a into master Nov 11, 2026
2 checks passed
@cygnet3
cygnet3 deleted the refactor/use-native-structs-tests branch November 11, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant