Skip to content

Refactor/sp address without network - #148

Merged
cygnet3 merged 5 commits into
masterfrom
refactor/sp_address_without_network
Aug 11, 2026
Merged

cygnet3 merged 5 commits into
masterfrom
refactor/sp_address_without_network

Conversation

@Sosthene00

Copy link
Copy Markdown
Collaborator

Replace #137

I propose to remove the network part of SilentPaymentAddress and have another SilentPaymentAddressDisplay type gated behind encode handle the stringification separately.

@Sosthene00
Sosthene00 force-pushed the refactor/sp_address_without_network branch 2 times, most recently from 5008f7d to ea5aaa9 Compare August 11, 2026 14:37
The example duplicated the documented usage and is superseded by the
SilentPaymentAddress/SilentPaymentAddressDisplay split.
… from version()

Rename SilentPaymentAddress::get_scan_key/get_spend_key/get_network/get_version
to scan_key/spend_key/network/version, and change version() to return SpVersion
instead of u8. Update all call sites.
Fix typo in version error message, replace match with if/else in
NonEmptyArray::new, and use expect() with messages instead of unwrap()
in bech32 encoding.
Remove the network from `SilentPaymentAddress` and isolate the whole
display logic in a new `SilentPaymentAddressDisplay` type. Add byte-array
constructors/serialization and network-agnostic constructors to
`SilentPaymentAddress`.
@Sosthene00
Sosthene00 force-pushed the refactor/sp_address_without_network branch from ea5aaa9 to 7015aad Compare August 11, 2026 14:59
@cygnet3
cygnet3 merged commit 0a937a9 into master Aug 11, 2026
2 checks passed
@cygnet3
cygnet3 deleted the refactor/sp_address_without_network branch August 11, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants