OvmfPkg/CloudHv: Activate Qemu's fw_cfg device - #9
Merged
Merged
Conversation
tpressure
reviewed
Aug 4, 2026
| QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf | ||
| QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | ||
| PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf | ||
| QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf |
There was a problem hiding this comment.
why did you change the line ordering here?
Author
There was a problem hiding this comment.
I actually don't know. I reverted to the old ordering.
|
LGTM, one question about the line ordering |
In Order to make the `fw_cfg` device available to OVMF and make it respect the `bootorder` file, we must include the respective driver. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
scholzp
force-pushed
the
activate_fw_cfg
branch
from
August 4, 2026 14:55
67d6f7b to
d37eb1e
Compare
tpressure
approved these changes
Aug 5, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to enable the
fw_cfgdevice to use in Cloud Hypervisor. We are currently implementing support for thebootorderentry and plan to fully support thefw_cfgdevice soon.It is part in solving: https://github.com/cobaltcore-dev/cobaltcore/issues/491
How This Was Tested
See https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/234