Skip to content

OvmfPkg/VirtioBlkDxe: protect SynchronousRequest against interrupts (e.g., timer) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phip1611 wants to merge 1 commit into from
Closed

OvmfPkg/VirtioBlkDxe: protect SynchronousRequest against interrupts (e.g., timer) #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions OvmfPkg/VirtioBlkDxe/VirtioBlk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ SynchronousRequest (
EFI_PHYSICAL_ADDRESS RequestDeviceAddress;
EFI_STATUS Status;
EFI_STATUS UnmapStatus;
EFI_TPL CurrentTpl;

BlockSize = Dev->BlockIoMedia.BlockSize;

Expand Down Expand Up @@ -365,6 +366,8 @@ SynchronousRequest (
goto UnmapDataBuffer;
}

CurrentTpl = gBS->RaiseTPL (TPL_NOTIFY);

@phip1611 phip1611 Apr 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this needs to be moved above Status = VirtioMapAllBytesInSharedBuffer ( 🤔


VirtioPrepare (&Dev->Ring, &Indices);

//
Expand Down Expand Up @@ -438,6 +441,7 @@ SynchronousRequest (
Status = EFI_DEVICE_ERROR;
}

gBS->RestoreTPL (CurrentTpl);
Dev->VirtIo->UnmapSharedBuffer (Dev->VirtIo, StatusMapping);

UnmapDataBuffer:
Expand Down
Loading