Skip to content

BUG: Observe notifications sent with wrong token #82

Description

@cvik

Severity: HIGH (from external code review)

ObserverRegistry.notify() encodes template with token = &.{0} (observe.zig:245). drainNotifications sends this template unchanged to every observer with a TODO for per-observer token patching.

RFC 7641 requires notifications include the client's registration token. Without it, clients cannot associate notifications with their observation.

Fix: Encode per-observer notifications with correct token, or patch the template per-observer before sending.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcriticalCritical bug — data corruption or security

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions