Enable TF32 matmuls and expose full BA diagnostics - #4
Closed
kevintsq wants to merge 1 commit into
Closed
Conversation
Set torch.set_float32_matmul_precision("high") in the end-to-end entrypoint.
The import has to come after load_mapping_runtime(): libtorch_cpu.so exports its
own statically linked BLAS/LAPACK, and when torch is loaded first those symbols
win global resolution for SuiteSparse/Ceres, so CHOLMOD reports "matrix not
positive definite" and bundle adjustment fails.
Bind the rest of BundleAdjustmentDiagnostics. Every field is populated in
PopulateResult, but only three were exposed, so the BA failure path in
adjuster.py raised AttributeError on termination_type instead of logging the
warning and restoring the last valid reconstruction.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
torch.set_float32_matmul_precision("high")in the end-to-end entrypoint. The import has to come afterload_mapping_runtime():libtorch_cpu.soexports its own statically linked BLAS/LAPACK, and when torch is loaded first those symbols win global resolution for SuiteSparse/Ceres, so CHOLMOD reports "matrix not positive definite" and bundle adjustment fails.Bind the rest of
BundleAdjustmentDiagnostics. Every field is populated inPopulateResult, but only three were exposed, so the BA failure path inadjuster.pyraisedAttributeErrorontermination_typeinstead of logging the warning and restoring the last valid reconstruction.