Repository navigation
VI-5068 Drop the flow-poll cache-buster that 8.2 stores reject - #26
Merged
Merged
Conversation
The growing-flow poll appended `&_t=<now>` to bypass API Gateway and CDN caching (98ebed4). A TAMS 8.2 store validates query parameters and answers an unknown one with 400, so every one of those polls has been failing against such a store -- invisibly, inside the catch that skips a failed source. The same URL without the parameter is what the re-check path already uses successfully. api.get fetches with cache: "no-store", so the parameter was carrying no weight in the browser either. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
VI-5068 — [tamstool] Upgrade TAMS Store Browser to TAMS 8.2
The bug
Against an 8.2 store,
/#/embedlogs a 400 every 5 seconds:Why
The growing-flow poll appends a cache-buster:
added in 98ebed4 to bypass API Gateway and CDN caching. A TAMS 8.2 store validates query parameters and rejects the unknown
_twith a 400, so every one of those polls has been failing against such a store — invisibly, since the loop ends incatch { /* skip */ }. It is part of why duration and LIVE never moved on a growing flow before #25.The same request without the parameter is what the re-check path in #25 already issues, successfully, against the same store and the same flow — which is the direct evidence that
_tis what the store objects to.The parameter was not earning its place in the browser either:
api.getalready fetches withcache: "no-store".The fix
Drop it. No replacement header —
Cache-Controlis not CORS-safelisted, and adding one would put the request at the mercy of each store's allowed-headers list for a problemno-storealready covers.Testing
npm run buildpasses (Node 22, same as CI)🤖 Generated with Claude Code