Repository navigation
Conversation
- Store each firmware field on its own, instead of skipping the charger - All three are nullable per the Zaptec API; drop the "not initialized" warning Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rhammen
added a commit
to rhammen/zaptec
that referenced
this pull request
Nov 8, 2026
…t-and-greatest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #415 for the chargers in #452 and in comments on #448, which omit
AvailableVersionandIsUpToDate.Setup no longer fails with #415, but the charger's firmware info is still skipped, even though
CurrentVersionis sent. The firmware entity stays unavailable, and a warning wrongly says the charger isn't initialized.This PR stores each field on its own, since all three are nullable in the API. An affected charger now shows its installed version, with state
unknownwhenAvailableVersionis missing. A charger with no version info also showsunknowninstead ofunavailable.I can't test this on a real charger, as mine still gets all the fields.
🤖 Generated with Claude Code