Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions custom_components/zaptec/number.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@

_LOGGER = logging.getLogger(__name__)

MIN_CHARGE_CURRENT = 6 # IEC 61851 minimum charging current (A)


class ZaptecNumber[ZaptecObjectT: ZaptecBase](ZaptecBaseEntity[ZaptecObjectT], NumberEntity):
"""Base class for Zaptec number entities."""
Expand Down Expand Up @@ -104,14 +106,27 @@ def _post_init(self) -> None:
async def async_set_native_value(self, value: float) -> None:
"""Update to Zaptec."""
self._log_number(value)
if not self.entity_description.setting:
setting = self.entity_description.setting
if not setting:
raise HomeAssistantError(f"No setting for {self.__class__.__qualname__}.{self.key}")

if setting == "minChargeCurrent":
max_current: float | None = self.zaptec_obj.get("charger_max_current")
if max_current is not None and value > max_current:
raise HomeAssistantError(
f"Min current {value} cannot be higher than max current {max_current}"
)
elif setting == "maxChargeCurrent":
min_current: float | None = self.zaptec_obj.get("charger_min_current")
if min_current is not None and value < min_current:
raise HomeAssistantError(
f"Max current {value} cannot be lower than min current {min_current}"
)

try:
await self.zaptec_obj.set_settings({self.entity_description.setting: value})
await self.zaptec_obj.set_settings({setting: value})
except Exception as exc:
raise HomeAssistantError(
f"Setting {self.entity_description.setting} to {value} failed"
) from exc
raise HomeAssistantError(f"Setting {setting} to {value} failed") from exc

await self.trigger_poll()

Expand Down Expand Up @@ -176,7 +191,7 @@ class ZapNumberEntityDescription(ZaptecEntityDescription, NumberEntityDescriptio
translation_key="charger_min_current",
device_class=NumberDeviceClass.CURRENT,
entity_category=EntityCategory.CONFIG,
native_min_value=0,
native_min_value=MIN_CHARGE_CURRENT,
native_max_value=32,
icon="mdi:current-ac",
native_unit_of_measurement=const.UnitOfElectricCurrent.AMPERE,
Expand Down
42 changes: 42 additions & 0 deletions tests/test_number.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
"""Tests for number.py."""

import pytest

from custom_components.zaptec.manager import ZaptecEntityDescription
from custom_components.zaptec.number import (
CHARGER_ENTITIES,
INSTALLATION_ENTITIES,
MIN_CHARGE_CURRENT,
ZapNumberEntityDescription,
)


def _find(descriptions: list[ZaptecEntityDescription], key: str) -> ZapNumberEntityDescription:
"""Return the entity description with the given key."""
return next(d for d in descriptions if d.key == key)


@pytest.mark.parametrize(
("descriptions", "key", "expected_min"),
[
pytest.param(
CHARGER_ENTITIES, "charger_min_current", MIN_CHARGE_CURRENT, id="charger_min_current"
),
# 0 holds the charger off rather than requesting a charging current.
pytest.param(INSTALLATION_ENTITIES, "available_current", 0, id="available_current"),
# Zaptec documents 0 as the way to force 3-phase charging.
pytest.param(
INSTALLATION_ENTITIES,
"three_to_one_phase_switch_current",
0,
id="phase_switch_current",
),
# Constrained relationally against charger_min_current, not by a static floor.
pytest.param(CHARGER_ENTITIES, "charger_max_current", 0, id="charger_max_current"),
],
)
def test_native_min_value(
descriptions: list[ZaptecEntityDescription], key: str, expected_min: float
) -> None:
"""Only charger_min_current declares the 6A floor."""
assert _find(descriptions, key).native_min_value == expected_min
Loading