You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor the state attributes to use the native Zaptec namespace. E.g. "DeviceType" and not do "device_type" rewrite.
I think we should wait with merging the PRs for v0.9.0 until we've released v0.8.8. Unless we want to start a development branch (but this have caveats, so I hope we can avoid this given that this community is not that active).
Let's use the milestone labels to actively select which fix goes where. Any discussions about the general high-level aspects of these releases should go here.
@steinmn and @rhammen you've been active lately. Any comments or things we should add or remove?
Both my open PRs are aimed at v0.8.8, non-breaking:
Fix ruff lint errors in api.py #390 covers the "fixup the last ruff changes in api.py" line item — it takes api.py to 0 ruff errors (ruff check clean), plus two small latent type fixes. One behavior note called out in the PR: the TRY301 fix moves the "stream already running" guard out of the try, so that error now propagates instead of being swallowed — happy to # noqa it instead if you'd rather keep the old behavior.
Add offline unit tests for the Zaptec API client #391 adds an offline unit-test suite for api.py (fake aiohttp session, no live login), lifting statement coverage ~13% → ~66%. Tests-only, so it's safe for a patch release, and it gives us a safety net before the 0.9.0 attribute work.
One thing to keep in mind for 0.9.0: #391's tests encode the current device_type-style snake_case attributes, so the "native Zaptec namespace" rewrite will need to update some of them — which is exactly what they're there to catch.
I'd suggest tagging both for the v0.8.8 milestone (I don't have access to set it myself).
Then there is #396 . This adds a Energy sensor for use in the Energy dashboard, that should be correct regarding actual time the charger used electricity.
For me, after a couple of debug iterations, this actually gives me the correct results.
For this one, I would like to get confirmation that it works correctly from more users.
I would say it is thus a "beta" feature.
Also scope is mainly (or only, once the previous PRs are merged ?) on the new statistics,py file, so regression risk for the basic functionality is low.
For this reason my suggestion is to include this one also in 0.8.8, but it is your call.
I've done some refinement of our open issues and placed issues into a backlog milestone. This was to separate the open user questions from work todo. Use it for issues we'd like to fix, but have no specific plan to fix. Anyone can pick up an issue from this milestone and fix them if they want.
PS! I'm the only one (active) that is able to assign milestones, so please do not hesitate to tag me if you want to have a PR or issue assigned to a specific release.
Right now we have a lot of active PRs (which is great). Some of them are stacked/chained PRs and are rather large with lots of AI assisted code. Are we getting so many that we should postpone them to 0.9.0? Where do we set the cut-off for 0.8.8? I'd prefer to keep this version small and uncomplicated. I believe we have users are waiting for pending improvements, such as #380.
These rather big and complicated PRs take time to review and they do pose a risk of something unexpected to happen. So my gut feeling is that we are heading into more unstable waters.
Right now we have a lot of active PRs (which is great). Some of them are stacked/chained PRs and are rather large with lots of AI assisted code. Are we getting so many that we should postpone them to 0.9.0? Where do we set the cut-off for 0.8.8? I'd prefer to keep this version small and uncomplicated. I believe we have users are waiting for pending improvements, such as #380.
These rather big and complicated PRs take time to review and they do pose a risk of something unexpected to happen. So my gut feeling is that we are heading into more unstable waters.
Having 414 in allows building other tests, for other changes/PRs, on top of that framework, so I'd prefer that one in. It is probably the biggest PR of them all.
There is also the migration to https://github.com/ha-zaptec-community (#411) and splitting the API and HA integration into separate repos to consider. The more we add to 0.8.8 here, the more we need to rework into the new repos.
Given that #414 seems to need to split the testing of API and HA anyway, and since it does not provide any direct user-facing benefits, I think it makes sense to do this after the migration.
(the updated version of) #397 seems simple and valuable enough to include in 0.8.8. The translations in #404 and #405 are also simple enough that merging them should be unproblematic. Other than that, I think maybe postponing the rest until after the migration would be my preference.
We should probably also update the readme with some info on the upcoming move to a different repo (for instance to have new issues created in the new repo insttead of the old).
Looking at the issues coming in, I think its urgent that we get v0.8.8 out the door. Its long over due. I've made a triage of PRs sorting them in what's urgent and what can wait.
@rhammen Please take a look at the set of PRs for the two milestones and see if you agree or if there is adjustments to be made please:
Once we've merged all PRs for the v0.8.8 release, I'll need your help to write the release notes for the release since you're the author of most of the fixes.
PS! (and not related to the release):
AI generated commits and PRs is often very wordy. As a (solo?) maintainer with too little time, getting a PR with very long texts makes it hard to get overview at a glance and I have to defer it to later. Please instruct your AI to compact the text. I think you'll find that the PR pass quicker with less text as they get less daunting. -- Same applies to git commits. They too are very wordy. Having squash merges with that much text is not wanted, so I often have to spend minutes on compacting the text into simple bullet points summarizing the PR.
@sveinse Agreed with the triage, both milestones look right to me.
Happy to write the release notes once the v0.8.8 PRs are merged.
Point taken on the wordy PRs and commits. I'll keep them short from now on.
I am willing to rewrite and shorten my open PR descriptions so you need to spent less time on reviewing them.
Would you prefer that?
Activity
rhammen commentedon Jul 8, 2026
Both my open PRs are aimed at v0.8.8, non-breaking:
api.py" line item — it takesapi.pyto 0 ruff errors (ruff checkclean), plus two small latent type fixes. One behavior note called out in the PR: theTRY301fix moves the "stream already running" guard out of thetry, so that error now propagates instead of being swallowed — happy to# noqait instead if you'd rather keep the old behavior.api.py(fakeaiohttpsession, no live login), lifting statement coverage ~13% → ~66%. Tests-only, so it's safe for a patch release, and it gives us a safety net before the 0.9.0 attribute work.One thing to keep in mind for 0.9.0: #391's tests encode the current
device_type-style snake_case attributes, so the "native Zaptec namespace" rewrite will need to update some of them — which is exactly what they're there to catch.I'd suggest tagging both for the v0.8.8 milestone (I don't have access to set it myself).
rhammen commentedon Jul 14, 2026
Given issue #400, We should also try to include #397.
#397 builds on top of:
My suggestion would be to include all these in 0.8.8
#398: ONLY changes test setup, so NO changes to functional code
My suggestion would be to include this one also in 0.8.8
rhammen commentedon Jul 14, 2026
Then there is #396 . This adds a Energy sensor for use in the Energy dashboard, that should be correct regarding actual time the charger used electricity.
For me, after a couple of debug iterations, this actually gives me the correct results.
For this one, I would like to get confirmation that it works correctly from more users.
I would say it is thus a "beta" feature.
Also scope is mainly (or only, once the previous PRs are merged ?) on the new statistics,py file, so regression risk for the basic functionality is low.
For this reason my suggestion is to include this one also in 0.8.8, but it is your call.
sveinse commentedon Jul 24, 2026
I've done some refinement of our open issues and placed issues into a backlog milestone. This was to separate the open user questions from work todo. Use it for issues we'd like to fix, but have no specific plan to fix. Anyone can pick up an issue from this milestone and fix them if they want.
PS! I'm the only one (active) that is able to assign milestones, so please do not hesitate to tag me if you want to have a PR or issue assigned to a specific release.
sveinse commentedon Jul 26, 2026
Where to set the bar for the
0.8.8releaseRight now we have a lot of active PRs (which is great). Some of them are stacked/chained PRs and are rather large with lots of AI assisted code. Are we getting so many that we should postpone them to
0.9.0? Where do we set the cut-off for0.8.8? I'd prefer to keep this version small and uncomplicated. I believe we have users are waiting for pending improvements, such as #380.These rather big and complicated PRs take time to review and they do pose a risk of something unexpected to happen. So my gut feeling is that we are heading into more unstable waters.
rhammen commentedon Jul 26, 2026
steinmn commentedon Jul 27, 2026
There is also the migration to https://github.com/ha-zaptec-community (#411) and splitting the API and HA integration into separate repos to consider. The more we add to 0.8.8 here, the more we need to rework into the new repos.
Given that #414 seems to need to split the testing of API and HA anyway, and since it does not provide any direct user-facing benefits, I think it makes sense to do this after the migration.
(the updated version of) #397 seems simple and valuable enough to include in 0.8.8. The translations in #404 and #405 are also simple enough that merging them should be unproblematic. Other than that, I think maybe postponing the rest until after the migration would be my preference.
We should probably also update the readme with some info on the upcoming move to a different repo (for instance to have new issues created in the new repo insttead of the old).
sveinse commentedon Oct 5, 2026
Looking at the issues coming in, I think its urgent that we get v0.8.8 out the door. Its long over due. I've made a triage of PRs sorting them in what's urgent and what can wait.
@rhammen Please take a look at the set of PRs for the two milestones and see if you agree or if there is adjustments to be made please:
Once we've merged all PRs for the v0.8.8 release, I'll need your help to write the release notes for the release since you're the author of most of the fixes.
PS! (and not related to the release):
AI generated commits and PRs is often very wordy. As a (solo?) maintainer with too little time, getting a PR with very long texts makes it hard to get overview at a glance and I have to defer it to later. Please instruct your AI to compact the text. I think you'll find that the PR pass quicker with less text as they get less daunting. -- Same applies to git commits. They too are very wordy. Having squash merges with that much text is not wanted, so I often have to spend minutes on compacting the text into simple bullet points summarizing the PR.
rhammen commentedon Oct 5, 2026
@sveinse Agreed with the triage, both milestones look right to me.
Happy to write the release notes once the v0.8.8 PRs are merged.
Point taken on the wordy PRs and commits. I'll keep them short from now on.
I am willing to rewrite and shorten my open PR descriptions so you need to spent less time on reviewing them.
Would you prefer that?