Repository navigation
fix: fail templating when a required secret name is unset - #73
Merged
Merged
Conversation
The value is documented as required, but it defaulted to "" and both
deployments wrapped API_SECRET in `{{- if }}`. A default install therefore
templated cleanly and ran the server with no API_SECRET, which the API reads
as the empty string.
Templating now fails and names the value instead. The director's API_URL
leaves the same conditional, since it has no meaning without the token.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfXo7wqpnNG8Ua2xsBidEc
…sword.secretName
Both are documented as required and both defaulted to "" behind a
`{{- if }}`, so a default install templated cleanly and then crash-looped:
validateOnPremMode lists BETTER_AUTH_SECRET and ON_PREM_PASSWORD among the
fields the server refuses to start without.
Templating now fails and names the value, so the error arrives at install
time rather than in a container log.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfXo7wqpnNG8Ua2xsBidEc
|
| Topic | Details | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| Required secrets | Require API_SECRET, BETTER_AUTH_SECRET, and ON_PREM_PASSWORD during deployment rendering, preventing empty credentials and ensuring director-to-server authentication and server startup requirements are enforced.Modified files (2)
Latest Contributors(2)
| |||||||||
| Secret documentation | Document the required secret behavior, credential purposes, and openssl commands for generating valid values.Modified files (2)
Latest Contributors(2)
|
Merger ✅ Ready to Merge
The chart now unconditionally requires all three secrets and documents the behavior; CI ran and there are no unresolved discussions or diff-confirmed blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner: @twk3
What and why
Three values are listed under Required in the configuration reference, default to
"", and were each read behind a{{- if ... }}. The conditional meant a defaulthelm installtemplated cleanly and dropped the environment variable instead of failing.currents.apiInternalToken.secretName— the server ran with noAPI_SECRET, whichpackages/apireads as''. The director also lostAPI_URL, so run fail-fast and CI cancellation were silently inert.currents.betterAuth.secretName,currents.rootUser.password.secretName—validateOnPremModelistsBETTER_AUTH_SECRETandON_PREM_PASSWORDamong the fields the server refuses to start without, so these crash-looped with the reason only in a container log.Each lookup now goes through
required, matching the chart's existing inline style (currents.sso.saml.metadataSecretName,currents.email.ses.region).API_URLleaves the director's conditional with the token, since it has no meaning without it.values.yamland the regenerateddocs/configuration.mdsay what each secret is for, that templating fails without it, and how to generate one.How it was tested
charts/currents/ci/lint-values.yamlsets all three and the lint workflow creates the matching secrets, soct lintandct installexercise the populated path.ON_PREM_PASSWORD,BETTER_AUTH_SECRETandAPI_SECRETpresent unconditionally.helm templateandhelm-docs. The sandbox proxy blocksget.helm.shand has no Docker daemon forscripts/build-docs.sh, so thedocs/configuration.mdrows are hand-written to match helm-docs' output (comment lines joined with single spaces, checked against the existing multi-linecurrents.redis.hostrow). Please let theDocs checkandLint and Test Chartsworkflows confirm both before merging.Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.