[IOS] Fix crash app when opening notification - #1
Open
cuestalvaro wants to merge 1 commit into
Open
Conversation
cuestalvaro
changed the title
alvaroscuesta
suggested changes
Jul 20, 2022
| void(^completionHandler)(void) = completionHandlers[handlerKey]; | ||
| if (completionHandler != nil) { | ||
| completionHandlers[handlerKey] = nil; | ||
| completionHandler(); |
There was a problem hiding this comment.
I think this line should not be deleted, because it would cause the app to crash
cuestalvaro
marked this pull request as draft
July 20, 2022 20:45
cuestalvaro
marked this pull request as ready for review
July 20, 2022 20:48
cuestalvaro
marked this pull request as draft
July 20, 2022 20:49
cuestalvaro
marked this pull request as ready for review
July 20, 2022 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter