Skip to content

fix: allow updating status of deployment versions with no jobs #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adityachoudhari26 wants to merge 1 commit into from
Closed

fix: allow updating status of deployment versions with no jobs #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/web/app/routes/ws/deployments/_components/versioncard/VersionCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ const NoActiveDeployments: React.FC<NoActiveDeploymentsProps> = ({
<span className="grow truncate overflow-ellipsis text-left">
{displayName}
</span>
<VersionDropdown version={version} />
</div>
</div>
</div>
Expand Down
62 changes: 36 additions & 26 deletions apps/web/app/routes/ws/deployments/_components/versioncard/VersionDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
DialogFooter,
DialogHeader,
DialogTitle,
DialogTrigger,
} from "~/components/ui/dialog";
import {
DropdownMenu,
Expand Down Expand Up @@ -57,20 +56,19 @@ const useUpdateVersionStatus = (versionId: string) => {

function VersionStatusDialog({
version,
children,
onClose,
open,
onOpenChange,
}: {
version: Version;
children: React.ReactNode;
onClose: () => void;
open: boolean;
onOpenChange: (open: boolean) => void;
}) {
const { updateStatus, isPending } = useUpdateVersionStatus(version.id);
const [status, setStatus] = useState<VersionStatus>(version.status);
const onClick = () => updateStatus(status).then(onClose);
const onClick = () => updateStatus(status).then(() => onOpenChange(false));
Comment on lines 67 to +68
Comment on lines 66 to +68

return (
<Dialog>
<DialogTrigger asChild>{children}</DialogTrigger>
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent>
<DialogHeader>
<DialogTitle>Update Version Status</DialogTitle>
Expand Down Expand Up @@ -108,30 +106,42 @@ function VersionStatusDialog({
}

export function VersionDropdown({ version }: { version: Version }) {
const [open, setOpen] = useState(false);
const [dropdownOpen, setDropdownOpen] = useState(false);
const [statusDialogOpen, setStatusDialogOpen] = useState(false);

return (
<DropdownMenu open={open} onOpenChange={setOpen}>
<DropdownMenuTrigger asChild>
<Button
variant="ghost"
size="icon"
className="h-7 w-7 shrink-0 text-muted-foreground"
onClick={(e) => e.stopPropagation()}
>
<EllipsisIcon className="size-3" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" onClick={(e) => e.stopPropagation()}>
<VersionStatusDialog version={version} onClose={() => setOpen(false)}>
<>
<DropdownMenu open={dropdownOpen} onOpenChange={setDropdownOpen}>
<DropdownMenuTrigger asChild>
<Button
variant="ghost"
size="icon"
className="h-7 w-7 shrink-0 text-muted-foreground"
onClick={(e) => e.stopPropagation()}
>
<EllipsisIcon className="size-3" />
</Button>
Comment on lines +116 to +123
</DropdownMenuTrigger>
<DropdownMenuContent align="end" onClick={(e) => e.stopPropagation()}>
<DropdownMenuItem
onSelect={(e) => e.preventDefault()}
onSelect={(e) => {
e.preventDefault();
setDropdownOpen(false);
setStatusDialogOpen(true);
}}
className="flex items-center gap-2"
>
<Flag className="h-4 w-4" />
Update Status
</DropdownMenuItem>
</VersionStatusDialog>
</DropdownMenuContent>
</DropdownMenu>
</DropdownMenuContent>
</DropdownMenu>

<VersionStatusDialog
version={version}
open={statusDialogOpen}
onOpenChange={setStatusDialogOpen}
/>
</>
);
}
Loading