Skip to content

chore: argo agent retries on context deadline err #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityachoudhari26 merged 2 commits into from
May 11, 2026
Merged

chore: argo agent retries on context deadline err #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80dfa7b
chore: argo agent retries on context deadline err
adityachoudhari26 May 11, 2026
214dd3d
cleanup
adityachoudhari26 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/workspace-engine/pkg/jobagents/argo/application_upserter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package argo

import (
"context"
"errors"
"fmt"
"log/slog"
"strings"
Expand Down Expand Up @@ -76,6 +77,9 @@ func isRetryableError(err error) bool {
if err == nil {
return false
}
if errors.Is(err, context.DeadlineExceeded) {
return true
}
errStr := err.Error()
return strings.Contains(errStr, "502") ||
strings.Contains(errStr, "503") ||
Expand All @@ -85,7 +89,8 @@ func isRetryableError(err error) bool {
strings.Contains(errStr, "timeout") ||
strings.Contains(errStr, "temporarily unavailable") ||
strings.Contains(errStr, "EOF") ||
strings.Contains(errStr, "Unavailable")
strings.Contains(errStr, "Unavailable") ||
strings.Contains(errStr, "context deadline exceeded")
Comment on lines 80 to +93
}

// GoApplicationDeleter is the production implementation of
Expand Down
6 changes: 6 additions & 0 deletions apps/workspace-engine/pkg/jobagents/argo/argoapp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,12 @@ func TestIsRetryableError(t *testing.T) {
{"Unavailable", fmt.Errorf("Unavailable"), true},
{"not found", fmt.Errorf("application not found"), false},
{"permission denied", fmt.Errorf("permission denied"), false},
{"context deadline exceeded sentinel", context.DeadlineExceeded, true},
{
"context deadline exceeded grpc status",
status.Error(codes.DeadlineExceeded, "context deadline exceeded"),
true,
},
}

for _, tt := range tests {
Expand Down
Loading