bug: unable to update status of dep version that has no jobs

[adityachoudhari26]

clicking on it opens the modal, but then clicking out of the modal closes it again, in the page.$deploymentId.tsx

[adityachoudhari26]

@claude fix this issue

[claude]

Claude finished @adityachoudhari26's task in 5m 32s —— View job • claude/issue-988-20260414-1849 • Create PR ➔

---

Fixing: Unable to update status of dep version with no jobs

• Gather context (read image, explore codebase)
• Identify the bug
• Fix VersionDropdown.tsx: lift dialog state outside the DropdownMenu
• Fix VersionCard.tsx: add VersionDropdown to NoActiveDeployments
• Commit and push changes

Root cause

Two related bugs:

1. Dialog closes immediately (VersionDropdown.tsx): VersionStatusDialog contained an uncontrolled Radix Dialog nested inside a controlled DropdownMenuContent. When the Dialog's overlay appeared, Radix's DismissableLayer fired onOpenChange(false) on the parent DropdownMenu, causing DropdownMenuContent to unmount — and the Dialog along with it. The dialog would open and immediately close.

   Fix: Converted VersionStatusDialog to a controlled Dialog (accepts open/onOpenChange props, no DialogTrigger). Moved its state to VersionDropdown alongside dropdownOpen, so the dialog lifecycle is independent of the dropdown.

2. No "Update Status" option for zero-job versions (VersionCard.tsx): The NoActiveDeployments component (rendered when a version has no active deployments/jobs) didn't include VersionDropdown, so there was no way to access "Update Status" for those versions.

   Fix: Added <VersionDropdown version={version} /> inside the NoActiveDeployments rotated content div.

Files changed

• apps/web/app/routes/ws/deployments/_components/versioncard/VersionDropdown.tsx
• apps/web/app/routes/ws/deployments/_components/versioncard/VersionCard.tsx

|