Fix alerts if user has view limit (#1531)#626
Open
abeverley wants to merge 1 commit into
Open
Conversation
droberts-ctrlo
left a comment
droberts-ctrlo
left a comment
Contributor
There was a problem hiding this comment.
Reviewed - no apparent issues
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - except a minor comment, all is well.
|
|
||
| my $filter = $view->filter; | ||
| my $view_id = $view->id; | ||
| trace qq(About to decode filter for view ID $view_id); |
Contributor
Author
There was a problem hiding this comment.
Thanks Pawel and good spot but this is actually a "proper" way of doing debugging in the code - these trace statements will only print anything when the log level is high enough.
There was a problem hiding this comment.
Understood, thanks for clarifying Andy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.