Skip to content

fix enrichr organism names - #469

Merged
jorisfu merged 2 commits into
devfrom
468-fix-enrichr-go-organism-options
Jul 27, 2026
Merged

fix enrichr organism names#469
jorisfu merged 2 commits into
devfrom
468-fix-enrichr-go-organism-options

Conversation

@jorisfu

@jorisfu jorisfu commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Description

fixes #468
Fixes the organism names for upstream enrichr

Changes

Lowercase 👍

Testing

Use any protein_df that comes from a t_test where we have a log2_foldchange column (e.g. significant_proteins_df). Perform a Gene Mapping step using the integrated uniprot DB on that df and connect the output and the protein df to GO Analysis (Enrichr API). Set the column to log2_fold_change and the threshold to 0, then check with different organisms and see that the enrichment does not crash because the organism id is invalid.

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The backend code has been formatted with black
  • The frontend code has been formatted with pnpm format and checked with pnpm lint

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@jorisfu
jorisfu requested a review from Elena-kal July 23, 2026 13:06
@github-actions

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  backend/protzilla/methods
  data_integration.py 300-311
Project Total  

This report was generated by python-coverage-comment-action

@Elena-kal Elena-kal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, when I followed your testing instructions though I got the following error:
Proteins must be a dataframe with Protein ID and direction of expression change column (e.g. log2FC)

Update: Nvm, works well.

@jorisfu
jorisfu merged commit 742d8ee into dev Jul 27, 2026
1 check passed
@jorisfu
jorisfu deleted the 468-fix-enrichr-go-organism-options branch July 27, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants