465 add scaling step - #467
Merged
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
jorisfu
requested changes
Jul 18, 2026
jorisfu
left a comment
Collaborator
There was a problem hiding this comment.
Tested working, but I'd personally add an error when the input max is smaller than the input min. It should work anyway (with the data flipped), but I think most of the time this is not intentional, so I suppose we need at least a warning or an error.
Also we do already have a lerp helper function that could make the code cleaner by using .apply() on the df with that function. Not insisting on this though
NeleRiediger
approved these changes
Jul 20, 2026
NeleRiediger
left a comment
Collaborator
There was a problem hiding this comment.
Seems to work fine and code looks good as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #465
This issue introduces a new step in which the intensity values can be scaled.
Changes
Added the new step to transformations in data_preprocessing and added new tests.
Testing
Create a standard workflow. Add the scaling step (I would assume one would usually want the scaling step after the normalization and log transformation). And check out how the data scales. The min value of the protein df given should map to the minimum value set in the parameters, same with the maximum values.
PR checklist
Development
Mergeability
blackpnpm formatand checked withpnpm lintCode review