Skip to content

461 log normalization method - #462

Merged
Elena-kal merged 7 commits into
devfrom
461-log-normalization-method
Jul 15, 2026
Merged

461 log normalization method#462
Elena-kal merged 7 commits into
devfrom
461-log-normalization-method

Conversation

@Elena-kal

@Elena-kal Elena-kal commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Description

fixes #461
Adds another version of the normalization by median method.

Changes

Made changes to the method, added option to choose the method in forms and added and adapted tests.

Testing

Create a standard workflow, run it with checking the box. Switch the order and run it without checking the box.

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The backend code has been formatted with black
  • The frontend code has been formatted with pnpm format and checked with pnpm lint

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@Elena-kal
Elena-kal requested review from 3dot141592, jorisfu and tE3m July 8, 2026 16:40
@Elena-kal Elena-kal self-assigned this Jul 8, 2026
@Elena-kal
Elena-kal removed the request for review from jorisfu July 8, 2026 16:40
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  backend/protzilla/data_preprocessing
  normalisation.py
  backend/protzilla/methods
  data_preprocessing.py 694
Project Total  

This report was generated by python-coverage-comment-action

@tE3m tE3m left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One larger question regarding the execution of the correction, apart from that just some nitpicks that are up to you. Solid work overall, I would've forgotten about the runner

Comment thread backend/protzilla/data_preprocessing/normalisation.py Outdated
Comment thread backend/protzilla/data_preprocessing/normalisation.py Outdated
Comment thread backend/protzilla/methods/data_preprocessing.py Outdated

@3dot141592 3dot141592 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as Tarek noted, I find it very counterintuitive that the log and normalization steps dont commute... Perhaps we could add a "shift variables around the median" checkbox, or make it a separate step.

Apart from that and the minor frontend bug, it looks good.

Comment thread backend/protzilla/methods/data_preprocessing.py Outdated
@Elena-kal
Elena-kal requested a review from 3dot141592 July 15, 2026 09:44
@Elena-kal
Elena-kal merged commit 36f5532 into dev Jul 15, 2026
1 check passed
@Elena-kal
Elena-kal deleted the 461-log-normalization-method branch July 15, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants