461 log normalization method - #462
Merged
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
tE3m
reviewed
Jul 12, 2026
tE3m
left a comment
Collaborator
There was a problem hiding this comment.
One larger question regarding the execution of the correction, apart from that just some nitpicks that are up to you. Solid work overall, I would've forgotten about the runner
3dot141592
requested changes
Jul 15, 2026
3dot141592
left a comment
Collaborator
There was a problem hiding this comment.
Just as Tarek noted, I find it very counterintuitive that the log and normalization steps dont commute... Perhaps we could add a "shift variables around the median" checkbox, or make it a separate step.
Apart from that and the minor frontend bug, it looks good.
3dot141592
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #461
Adds another version of the normalization by median method.
Changes
Made changes to the method, added option to choose the method in forms and added and adapted tests.
Testing
Create a standard workflow, run it with checking the box. Switch the order and run it without checking the box.
PR checklist
Development
Mergeability
blackpnpm formatand checked withpnpm lintCode review