Track per-team solve attempts with timestamped correctness state#30
Draft
Copilot wants to merge 18 commits into
Draft
Track per-team solve attempts with timestamped correctness state#30Copilot wants to merge 18 commits into
Copilot wants to merge 18 commits into
Conversation
Copilot
AI
changed the title
[WIP] Add store for solve-attempt times and states
Track per-team solve attempts with timestamped correctness state
Apr 11, 2026
Agent-Logs-Url: https://github.com/csboo/apollo/sessions/f6216e44-f616-4a05-ae69-cbf6cddb62ef Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
3091f5e to
c82a9f1
Compare
Collaborator
|
@dependabot rebase |
Collaborator
|
@copilot rebase |
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Author
Collaborator
|
@copilot rebase |
Collaborator
|
@copilot drop jiff, use systemtime |
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/csboo/apollo/sessions/f6216e44-f616-4a05-ae69-cbf6cddb62ef Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
…s' into copilot/store-solve-attempt-times # Conflicts: # Cargo.toml # src/backend/endpoints.rs # src/backend/models.rs Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Collaborator
|
@copilot rebase |
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Co-authored-by: jarjk <118479592+jarjk@users.noreply.github.com>
Author
jarjk
reviewed
Apr 23, 2026
| }; | ||
| solution.zeroize(); | ||
| is_solution_valid.or_forbidden("érvénytelen megoldás ehhez a feladathoz")?; | ||
| let is_correct = is_solution_valid; |
jarjk
reviewed
Apr 23, 2026
| use std::time::UNIX_EPOCH; | ||
|
|
||
| #[test] | ||
| fn marks_puzzle_as_solved_only_for_correct_attempts() { |
Collaborator
There was a problem hiding this comment.
this doesn't actually test anything, have a look at insta then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates team progress tracking from a solved-set model to an append-only attempt history, recording both correctness and attempt time for each submission.
What changed
Vec<SolveAttempt>.SolveAttempt { puzzle_id, attempted_at, correct }.std::time::SystemTime(droppedjiffusage).team_has_solved_puzzle).Validation
house-keeping(stacked PR base).make checksuccessfully after updates.