Repository navigation
Conversation
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The SD host can only read: psbt files and exported wallet descriptors (<Name>.json) can be removed only from a PC. This adds "Delete a file" and "Delete ALL files" to the picker, a best-effort secure delete (os.urandom overwrite + fsync + remove), and keeps the picker open after a delete instead of dropping to the main menu. Adds 11 tests with a fake GUI and a real filesystem, including a check that the content is overwritten before os.remove. Closes #359
mak777uh
force-pushed
the
sd-card-delete-files
branch
from
October 25, 2026 21:32
e3d9938 to
42ab67e
Compare
Author
|
Evidence of related work, in case it helps with review: https://github.com/mak777uh/cases — one folder per direction of work, each with the claim, the evidence, how to reproduce it, a verdict of confirmed / not confirmed / could not tell, and the limits. The SD-card case is #101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SD host can only read files: psbt files and exported wallet descriptors can be removed only from a PC. This adds 'Delete a file' and 'Delete ALL files' to the picker, a best-effort secure delete, and keeps the picker open after a delete instead of dropping to the main menu. Adds tests with a fake GUI and a real filesystem.