Skip to content

Add web Specter DIY Web simulator connection - #431

Closed
schnuartz-ai wants to merge 16 commits into
cryptoadvance:masterfrom
Schnuartz:codex/cryptoadvance-linkage
Closed

schnuartz-ai wants to merge 16 commits into
cryptoadvance:masterfrom
Schnuartz:codex/cryptoadvance-linkage

Conversation

@schnuartz-ai

@schnuartz-ai schnuartz-ai commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Use the same full simulator commit SHA for the reusable browser build, its tooling checkout, and the trusted publisher workflow.
  • Pass every required publisher input, and declare the manual pr_number input as a number to match the reusable browser workflow.
  • Have the trusted workflow_run publisher reject successful artifacts whose simulator repository or commit differs from its configured pin.
  • Skip stale default-branch runs so a slower build cannot replace a newer stable preview.
  • Keep Pages publishing and PR-comment permissions in the trusted Specter DIY workflow.

Validation

  • Resolver tests: 4 passed; trusted publisher tests: 10 passed.
  • Python compilation, workflow YAML parsing, reusable-workflow input/pin contract checks, and git diff --check pass locally.
  • GitHub Actions will validate the pushed revision; no merge has been performed.

@netlify

netlify Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for specter-diy-docs ready!

Name Link
🔨 Latest commit e789e8b
🔍 Latest deploy log https://app.netlify.com/projects/specter-diy-docs/deploys/6abe2102da3f600008cac70e
😎 Deploy Preview https://deploy-preview-431--specter-diy-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@schnuartz-ai schnuartz-ai changed the title Use reusable simulator workflows Add web Specter DIY Web simulator connection Sep 28, 2026
@Schnuartz

Copy link
Copy Markdown
Contributor

@al-munazzim can you review this PR?

@al-munazzim

Copy link
Copy Markdown
Contributor

Thanks for the ping. I checked the current PR state: this is still marked as draft, the latest head is e789e8b, and the GitHub checks are green (firmware/native/tests/browser simulator all passing; Debricked/Netlify informational contexts are neutral/success).

Given the size and security-sensitive workflow changes here, I would not treat this as merge-ready just from CI. Before requesting final maintainer approval, please mark it ready-for-review and call out the intended trust boundary explicitly in the PR description, especially:

  • the exact simulator repo/SHA pinning path used by Build vs Publish;
  • why the write-enabled publisher never executes PR-controlled code or artifacts;
  • the stale-run protections for both PR previews and default-branch stable publishing;
  • any remaining manual Pages/GitHub environment setup required after merge.

No duplicate triage action from me beyond this initial state check while it remains draft.

@schnuartz-ai

Copy link
Copy Markdown
Contributor Author

Closing: superseded by #440 (dispatcher) together with cryptoadvance/specter-diy-web-simulator#8, which implement the two-repository preview architecture. No separate review needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants