add = 1 to WebsitePeople $pageNumber arguments for consistency with other classes#44
Open
ziming wants to merge 1 commit into
Open
add = 1 to WebsitePeople $pageNumber arguments for consistency with other classes#44ziming wants to merge 1 commit into
ziming wants to merge 1 commit into
Conversation
ziming
changed the title
Member
|
Hey there. I see two different pull requests, but seems the other one contains this current PR changes. Do you confirm? |
Contributor
Author
|
you can merge this 1 first then i edit the other PR after that to be consistent The other PR is about adding a new method. This 1 is about default argument $pageNumber = 1 |
Contributor
Author
|
@baptistejamin there is only 1 PR now, I closed the other one for now to reduce confusion for you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the title