Repository navigation
fix: enable IUTF8 input flag by default on darwin pseudo-terminals - #218
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Set the IUTF8 flag in termios iflag on darwin when opening a pseudo-terminal. Without IUTF8, the Darwin terminal driver line discipline deletes single bytes instead of whole UTF-8 characters when backspace/delete (0x7f) is sent, resulting in mangled multibyte characters in canonical mode. Fixes creack#138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the IUTF8 flag in termios c_iflag on Darwin pseudo-terminals during open.
On macOS, the kernel terminal driver defaults newly allocated pseudo-terminals to canonical mode without the IUTF8 flag enabled. When multibyte UTF-8 characters (such as CJK characters) are typed and subsequently erased with the Delete key (0x7f) or backspace, the terminal driver deletes only the final byte instead of the complete multibyte character, leaving corrupt byte sequences in canonical line buffers.
Enabling IUTF8 by default on the slave tty allows the terminal driver line discipline to correctly recognize multibyte UTF-8 character boundaries during line editing.
Fixes #138