Repository navigation
fix: correct struct padding for freebsd amd64 termios - #217
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Remove obsolete Pad_cgo_0 padding field from fiodgnameArg in ztypes_freebsd_amd64.go. Go automatically aligns 64-bit pointers to 8 bytes, matching FreeBSD sys/filio.h struct fiodgname_arg layout without explicit padding fields. Fixes creack#90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the explicit Pad_cgo_0 padding field from fiodgnameArg in ztypes_freebsd_amd64.go.
On FreeBSD amd64, struct fiodgname_arg in <sys/filio.h> consists of an int32 length followed by a pointer buffer. Under Go 64-bit struct alignment rules, pointer fields are naturally 8-byte aligned, providing the exact required 4-byte padding between Len and Buf. The explicit Pad_cgo_0 field was an artifact from older cgo -godefs generation and is inconsistent with other FreeBSD 64-bit architectures (arm64, riscv64).
Fixes #90