test(ci): harden PHAR tests against silent phar.readonly skips (closes #340)#554
Merged
Merged
Conversation
added 2 commits
July 3, 2026 23:23
…#340) - Add -d phar.readonly=0 to composer test and test:coverage scripts - Add phar.readonly=0 to CI workflow ini-values for visibility - Add PharReadOnlyGuardTest: fails under CI when phar.readonly is set without WORKERMAN_ALLOW_PHAR_READONLY_SKIP opt-out - Refactor BuildPharCommandTest::testCommandFailsWhenPharReadonlyIsSet to use injected PharCapabilities instead of runtime INI check - Rector removes now-unused createCommand() helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #340
PHAR-build tests were silently skipping when
phar.readonlywas set, hiding potential regressions behind a green CI build.Changes
-d phar.readonly=0tocomposer testandcomposer test:coveragescripts so PHAR tests always run locallyphar.readonly=0to CI workflowini-valuesfor visibility in the workflow filePharReadOnlyGuardTest— a guard test that fails under CI whenphar.readonlyis set without theWORKERMAN_ALLOW_PHAR_READONLY_SKIPopt-out env varBuildPharCommandTest::testCommandFailsWhenPharReadonlyIsSetto use injectedPharCapabilities(true, true)instead of depending on the runtime INI setting (this test was previously always skipped withphar.readonly=0)Changelog
Code Review
phar.readonly=0