Skip to content

feat(tests): harden UtilsTest signal-logic tests with CI guard and pcntl/posix extensions (closes #346)#553

Merged
s2x merged 4 commits into
masterfrom
feat/issue-346-utilstest-pcntl-posix-ci
Jul 3, 2026
Merged

feat(tests): harden UtilsTest signal-logic tests with CI guard and pcntl/posix extensions (closes #346)#553
s2x merged 4 commits into
masterfrom
feat/issue-346-utilstest-pcntl-posix-ci

Conversation

@s2x

@s2x s2x commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #346

Changes

  • Add pcntl and posix extensions to CI test runner via shivammathur/setup-php
  • Add testSignalExtensionsAvailable guard test that fails when extensions are missing unless WORKERMAN_ALLOW_PCNTL_SKIP=1 is set
  • Document the skip behavior in CONTRIBUTING.md for macOS contributors
  • Update CHANGELOG.md under [Unreleased]

Changelog

Harden UtilsTest signal-logic tests with CI guard and pcntl/posix extensions.

Code Review

  • Passed subagent code review
  • All review comments addressed

@s2x s2x self-assigned this Jul 3, 2026
@s2x
s2x merged commit 5b12002 into master Jul 3, 2026
12 checks passed
@s2x
s2x deleted the feat/issue-346-utilstest-pcntl-posix-ci branch July 3, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] UtilsTest skips signal-logic tests without pcntl/posix — macOS contributors get a green build

1 participant