fix(core): eliminate status/connections file race conditions on macOS (closes #535)#541
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #535
WorkermanCommandTest fails on macOS because of a race condition in status/connections file reading. Workerman's SIGIOT handler truncates the status file to 0 bytes before writing content. PHP's stat cache combined with stale status files from interrupted runs causes
waitForFile()to detect the file before content is written, returning empty or partial data.Changes
StatusFileReader::waitForFile(): Callclearstatcache()before each poll to avoid cached stale stats. Reject 0-byte files (written during the SIGIOT handler's truncate phase).ServerManager::getStatus()/getConnections(): Delete the stale status/connections file@unlink()before sending SIGIOT/SIGIO, sowaitForFile()always waits for fresh output from the current signal.StatusFileReaderTest: Write content to the temp file intestWaitForFileReturnsTrueWhenFileExists(previously empty). AddtestWaitForFileReturnsFalseWhenFileEmptyto cover the 0-byte rejection path.Changelog
Fix race condition in
ServerManager::getStatus()/getConnections()where PHP's stat cache and stale status files could causewaitForFile()to read an empty or incomplete file.StatusFileReader::waitForFile()now clears the stat cache per poll and rejects 0-byte files.ServerManagerdeletes the stale file before signaling, ensuring fresh output is waited for.Code Review