test: expand ProcessTest to cover full process lifecycle (closes #348)#538
Merged
Conversation
- Add ProcessEventRecorder test listener that writes marker files on ProcessStartEvent and ProcessErrorEvent dispatch - Add TestErrorProcess that throws RuntimeException to exercise the error path - Add ProcessMarkerPaths constants class as shared source of truth for marker file paths between recorder and test - Expand ProcessTest from a single PID-file recency check to: * testProcessIsLive — status file recency (regression for restart cycle) * testProcessStartEventIsDispatched — start event regression check * testNoProcessErrorEventDuringNormalOperation — negative assertion * testProcessErrorEventIsDispatchedOnThrowable — error event regression * testProcessSurvivesSigtermAndIsRestartedBySupervisor — signal handling - Update bootstrap.php to clean up marker files on stop - Update CHANGELOG.md under [Unreleased] Tests section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #348
Changes
ProcessEventRecordertest listener that writes marker files onProcessStartEventandProcessErrorEventdispatchTestErrorProcessthat throwsRuntimeExceptionto exercise the error pathProcessMarkerPathsconstants class as shared source of truth for marker file paths between recorder and testProcessTestfrom a single PID-file recency check to full lifecycle coverage:testProcessIsLive— status file recency (regression for restart cycle)testProcessStartEventIsDispatched— start event regression checktestNoProcessErrorEventDuringNormalOperation— negative assertiontestProcessErrorEventIsDispatchedOnThrowable— error event regressiontestProcessSurvivesSigtermAndIsRestartedBySupervisor— signal handling (locates worker PID via/procon Linux orpson macOS)bootstrap.phpto clean up marker files on stopCHANGELOG.mdunder [Unreleased] Tests sectionChangelog
Process lifecycle test expansion documented under [Unreleased] → Tests.
Code Review
\x1fdelimiter, cross-platform PID lookup)