fix: enforce explicit SSL verification in embedding API requests (closes #80)#158
Merged
Conversation
#80) Add CURLOPT_SSL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST to the curl_setopt_array() call in ApiEmbeddingFunction::post(), ensuring SSL verification is always explicit regardless of global PHP curl settings (e.g. curl.cainfo=""). Changes: - src/embeddings/EmbeddingInterfaces.php: replaced 5 individual curl_setopt() calls with curl_setopt_array() including SSL options - tests/test_embedding_ssl_verify.phpt: static analysis test for SSL constant presence and correct values - tests/test_embedding_ssl_verify.php: legacy test with detailed checks (post() scope, ordering, proxy separation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #80
Changes
curl_setopt()calls with a singlecurl_setopt_array()call that includesCURLOPT_SSL_VERIFYPEER => trueandCURLOPT_SSL_VERIFYHOST => 2. Proxy configuration remains a separatecurl_setopt()call (unchanged).Testing
php tests/test_embedding_ssl_verify.php— PASSphp run-tests.php tests/test_embedding_ssl_verify.phpt— PASSCode Review