Repository navigation
fix(web): preserve global OPTIONS and cover metadata boundaries - #43
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The security-sensitive metadata and concurrent body-wrapper changes span multiple HTTP protocol implementations and warrant final human review.
Review effort: Balanced
Findings: None
What changed in this PR
Routes global OPTIONS * through cover handlers and hardens cover metadata filtering across HTTP protocols.
Changes:
- Preserves
OPTIONS *semantics for static and fixed-origin covers. - Retains original connection nominations when filtering late trailers.
- Removes relay-owned authentication metadata from public cover traffic.
| File | Description |
|---|---|
internal/tunnel/web_h2.go |
Disables automatic OPTIONS interception. |
internal/tunnel/web_cover_options_test.go |
Tests OPTIONS behavior across H1/H2/H3. |
internal/tunnel/web_cover_metadata_test.go |
Tests metadata filtering and streaming. |
internal/cover/metadata_policy_test.go |
Covers nomination and authentication policies. |
internal/cover/handler.go |
Implements routing and metadata filtering. |
docs/WEB_COVER.md |
Documents the new behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
OPTIONS *through the configured cover on H1/H2/H3. Static cover returns its normal 405/Allow and combined bound Alt-Svc; fixed-origin cover preserves*without attaching a configured resource prefix/query.Verification
make checkandmake racepass (Go 1.25.13).Limits
No release/tag, production deployment, old remote-machine use, or large capture campaign. This is ordinary HTTP compatibility and metadata-boundary evidence, not real-browser fingerprint equivalence or comparative traffic-identification evidence. The native upstream parser's documented Connection-close nomination information-loss limit is unchanged.
Post-merge verification
Merged as
bd4efe25405e7ff5fccb7031d9eeedc3d757154bwith the exact tested tree. Main push attempt 1 CI (11/11), CodeQL and native Linux netem all pass. Main's actual container integration and amd64/arm64 OCI export complete; the local clean main tree equals the frozen source and all ten new regression names pass three more race runs. No release or production deployment was performed.