fix(iocp): block indefinitely when idle instead of polling every 500ms#295
Merged
Merged
Conversation
The IOCP scheduler and its auxiliary wait reactor both capped their blocking wait (GetQueuedCompletionStatus / WSAPoll) at 500ms. The 500ms came from Asio's default_gqcs_timeout, but Asio applies it only on pre-Vista Windows to work around a GQCS bug; on Vista+ it uses INFINITE. corosio targets modern Windows only, and timers, posted work, and reactor registrations already wake their loops precisely (waitable timer thread, PostQueuedCompletionStatus, self-pipe). So: - Both loops now block indefinitely; only the failed wake-up post/send is fatal (matches Asio), since it can only fail under resource exhaustion. - The one-time shutdown drain loop keeps a finite wait so it makes progress. - Remove the gqcs_timeout_ms option and configure_iocp(): its only effect was forcing idle wake-ups, and Asio does not expose it.
|
An automated preview of the documentation is available at https://295.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-30 19:53:55 UTC |
|
GCOVR code coverage report https://295.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-06-30 20:00:24 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IOCP scheduler and its auxiliary wait reactor both capped their blocking wait (GetQueuedCompletionStatus / WSAPoll) at 500ms. The 500ms came from Asio's default_gqcs_timeout, but Asio applies it only on pre-Vista Windows to work around a GQCS bug; on Vista+ it uses INFINITE. corosio targets modern Windows only, and timers, posted work, and reactor registrations already wake their loops precisely (waitable timer thread, PostQueuedCompletionStatus, self-pipe). So: