fix: stop the closed search box from covering the GitHub button - #69
Merged
Merged
Conversation
On the home page, clicking the left part of the GitHub button in the header focused the search input and opened search, and hovering it showed the browser's "Please fill out this field" tooltip. Only the right part of the button opened GitHub. Closed, the search form is a 44px button, but Material's `.md-search__input` and `.md-search__suggest` keep their `2.2rem` side padding, so they are 88px wide and stick out 44px to the right. The input has `z-index: 2`, so the overflow sat on top of the GitHub button next to it. This clips the closed form with `overflow: hidden`; the open form (560px) is unchanged. Checked with `mkdocs serve` at 965, 1024 and 1440px wide: `elementFromPoint` across the GitHub button now returns the link at every point (before: the search input over its left 30%), the search icon still opens search, and a query still returns results. Inner pages don't use this header.
✅ Deploy Preview for cpp-linter-github-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the home page, clicking the left part of the GitHub button in the header focused the search input and opened search, and hovering it showed the browser's "Please fill out this field" tooltip. Only the right part of the button opened GitHub.
Closed, the search form is a 44px button, but Material's
.md-search__inputand.md-search__suggestkeep their2.2remside padding, so they are 88px wide and stick out 44px to the right. The input hasz-index: 2, so the overflow sat on top of the GitHub button next to it. This clips the closed form withoverflow: hidden; the open form (560px) is unchanged.Checked with
mkdocs serveat 965, 1024 and 1440px wide:elementFromPointacross the GitHub button now returns the link at every point (before: the search input over its left 30%), the search icon still opens search, and a query still returns results. Inner pages don't use this header.