Support arbitrary code lengths. Fixes #11. - #12
Open
JackZielke wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support code lengths other than 6.
When adding codes, the default is 6 digits unless otherwise specified. Max length is 10.* This bumps the version since the config page is incompatible with the old version. The new code needs the code lengths and the new config page provides them. I have not tested the old app with the new config page. I expect the old code to ignore the lengths and still work.
PR #6 hardcoded the name and reduced the font size for all codes. This version reduces the font when needed and provides an optional number of digits on the config page.