Repository navigation
minimax-h3 0.16.0rc2: vae_round_trip's decode times the VAE alone (cr-306) - #960
Merged
Merged
Conversation
…s MP4 is written after (cr-306) Its decode handed each chunk to the MP4 writer as generate does, so vae_decode also timed the host's video encoder running beside it: 7.8 s on gate 44090355818's pod (CPU-slow: read_video 3.8 s), 4.5 s on pod-session 44082684755's. The frames land on the host during vae_decode, as ComfyUI's VAEDecode lands its, and save_video writes them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cr-306.
vae_round_triphanded each decoded chunk to the MP4 writer asgeneratedoes, so itsvae_decodestage also timed the host's video encoder running beside it: the release-gate cellh3-vae(cozy-creator #3721) read 7.8 s on gate 44090355818's pod (CPU-slow:read_video3.8 s against 0.74 s, 451 W cap) where pod-session 44082684755's read 4.5 s. The frames now land on the host duringvae_decode, as ComfyUI's VAEDecode lands its, andsave_videowrites the MP4 after. No other function changes.Proof
The release-gate red and green runs of
h3-vaeon this commit follow on cr-306 (the cell reads the stage this changes); the decode path itself isvae_round_trip's since #956, unchanged.