Repository navigation
orbit: its video says it's an orbit, every frame a keyframe (cl-1131) - #957
Draft
PaulFidika wants to merge 1 commit into
Draft
PaulFidika wants to merge 1 commit into
PaulFidika wants to merge 1 commit into
Conversation
Paul, 11-17: "videos can be marked as 'orbit' videos (a property of the video). In that case, they get a
special player; you can grab the image and spin it around". orbit defined TURN from 0.1.0 and never put it
on its output, so its videos played. Now save_video_stream keys every frame and the video carries
{"orbit": TURN} (File.with_metadata, xs-180).
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cl-1131. Paul, 11-17: "videos can be marked as 'orbit' videos (a property of the video). In that case, they get a special player … Currently instead they are treated just as regular videos".
orbithas definedTURN = {degrees: 360, direction: cw, loops: true}since 0.1.0 but never put it on its output. se-116's "declares orbit, every frame a keyframe" box was never done. As a result:orbitmetadata. Paul's are 361 frames with 16 keyframes.The fix:
save_video_stream(..., keyframe_interval=1).saved.video.with_metadata({"orbit": TURN}).Both use the Runtime 0.47 API (xs-180) and add no new author API. Outputs made before this get re-rendered (main, 11-17: no Calcifer special case; pre-launch, no legacy support).
Proof
mypy --stricton orbit: clean. ruff:__init__.pyclean.orbit(cozy-creator#3707),packages_refs= this branch at 7b20513.orbit/orbitfrom source, run 3: the picture is release-gate/ref/seed.jpg, subject lighthouse, 15 s, rendered from the page's Focus Render.{"orbit":{"degrees":360,"direction":"cw","loops":true}}, 361 frames, all 361 keyframes (ffprobe). Paul's earlier ones have 16.