Skip to content

orbit: its video says it's an orbit, every frame a keyframe (cl-1131) - #957

Draft
PaulFidika wants to merge 1 commit into
rc/0.26.0from
claude/cl-1131-orbit-videos
Draft

PaulFidika wants to merge 1 commit into
rc/0.26.0from
claude/cl-1131-orbit-videos

Conversation

@PaulFidika

@PaulFidika PaulFidika commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

cl-1131. Paul, 11-17: "videos can be marked as 'orbit' videos (a property of the video). In that case, they get a special player … Currently instead they are treated just as regular videos".

orbit has defined TURN = {degrees: 360, direction: cw, loops: true} since 0.1.0 but never put it on its output. se-116's "declares orbit, every frame a keyframe" box was never done. As a result:

  • Its videos carried no orbit metadata. Paul's are 361 frames with 16 keyframes.
  • Once the page's Orbit switch went (xs-180, 11-16), every orbit played like a normal video.

The fix:

  • save_video_stream(..., keyframe_interval=1).
  • The video is returned as saved.video.with_metadata({"orbit": TURN}).

Both use the Runtime 0.47 API (xs-180) and add no new author API. Outputs made before this get re-rendered (main, 11-17: no Calcifer special case; pre-launch, no legacy support).

Proof

  • mypy --strict on orbit: clean. ruff: __init__.py clean.
  • GPU, pod-session 44061591892: PASSED. Session orbit (cozy-creator#3707), packages_refs = this branch at 7b20513.
    • Pod: 1x rtx-3090 sylpha (sm_86, 24 GiB), RC builds: cozy 0.26.0-dev+gec8ec2ae, Runtime 0.47.0.dev2306+gca841fe7.
    • orbit/orbit from source, run 3: the picture is release-gate/ref/seed.jpg, subject lighthouse, 15 s, rendered from the page's Focus Render.
    • Its version's file: {"orbit":{"degrees":360,"direction":"cw","loops":true}}, 361 frames, all 361 keyframes (ffprobe). Paul's earlier ones have 16.
    • The page: the mark at rest. In Focus, no play button or timeline; a quarter-width drag lands on 90°, frame 90 of 361. In full screen, a half-width drag lands on 180°, frame 180. The screenshots show the lighthouse turning: the picture's view at 0°, its side at 90°, behind it at 180°.
    • The cell took 1009.6 s. The pod was ended and is GONE: 1234 s, $0.229 billed (unmetered).

Paul, 11-17: "videos can be marked as 'orbit' videos (a property of the video). In that case, they get a
special player; you can grab the image and spin it around". orbit defined TURN from 0.1.0 and never put it
on its output, so its videos played. Now save_video_stream keys every frame and the video carries
{"orbit": TURN} (File.with_metadata, xs-180).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant