Repository navigation
Fix log determinants with constant Kronecker diagonal noise - #162
Open
DiadkoShmek wants to merge 1 commit into
Open
DiadkoShmek wants to merge 1 commit into
DiadkoShmek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logdet()can raiseAttributeError: 'Tensor' object has no attribute 'linear_ops'when an added diagonal is a Kronecker product of constant-diagonal factors and the matrix reaches the existing fast-path threshold. A 1024-dimensional covariance triggers this with default settings, also blocking Gaussian log-probability evaluation.Recognize this constant diagonal locally in
_logdetand reuse the existing spectral shift,logdet(K + dI) = sum(log(eigenvalues(K) + d)). This removes the broken factor reconstruction and its incorrect scaling, while preserving the existing small-matrix fallback and solve/root routes.BASE raises at
matrix.logdet(); the change returns approximately2536.626652357273, matching the diagonal reference without overriding any settings.CPU validation:
docs/source/conf.py. No warning suppression or warning-free claim.This is a constant-noise log-determinant repair, not a general Kronecker higher-derivative, solve/root, GPU or performance claim.
I directed this work and take responsibility for the contribution and its follow-up. AI assistance was used in producing the change.