Repository navigation
Preserve diagonal batch axes in block-diagonal products - #161
Open
DiadkoShmek wants to merge 1 commit into
Open
DiadkoShmek wants to merge 1 commit into
DiadkoShmek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block-diagonal/diagonal multiplication reshapes the diagonal operand using the block operand's batch axes. Broadcast-compatible prefixes can therefore fail to reshape or silently move scenarios to the wrong axis. For example:
Split only the diagonal event axis into
(num_blocks, block_size), retaining that operand's own batch prefix. The existing block multiplication then performs normal broadcasting. This requires one reshape correction in each multiplication order, without materializing the full matrix. A collapsed covariance batch can also produce an incorrect Gaussian density when a public distribution broadcasts it against its mean.Validation is CPU-only:
docs/source/conf.py. No warning suppression or warning-free claim.This preserves supported operand broadcasting; it does not redesign incompatible dimensions or arbitrary reshapes. No full repository/nightly numerical suite, GPU, complex/empty-event support, higher AD or performance improvement is claimed. Known noninterleaved multitask-density mapping behavior is outside this repair; the public Gaussian checks use the default interleaved path. The separate triangular-solve change in #158 is not included.
I directed this work and take responsibility for the contribution and its follow-up. AI assistance was used in producing the change.