Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elementwise multiplication by
IdentityLinearOperatorcurrently returns the other matrix unchanged, including its off-diagonal entries. It can also lose the identity's batch dimensions.This uses the inherited diagonal multiplication and explicitly constructs constant-diagonal products, avoiding an incompatible identity constructor.
I * Inow returns an equivalentConstantDiagLinearOperator.The regressions cover tensors, dense operators, identities and constant-diagonal operators, including batches and both operand orders. They fail on the base and pass with the fix. Formatting and lint checks pass. The full local suite has the same two existing batch-repeat SVD failures before and after the change.