Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable higher-order matrix derivatives through triangular matmul by delegating the bilinear VJP to the wrapped operator. The triangular wrapper preserves the representation, so it can retain an existing analytic derivative instead of using the generic detached autograd fallback.
For
TriangularLinearOperator(L).matmul(z).square().sum()with constantz, the first derivative currently hasrequires_grad=False, although dense matmul has a nonzero matrix Hessian. This also loses a term when differentiating Cholesky-root samples twice through their covariance parameters. This is a narrow higher-order-autograd enhancement; it does not assert a library-wide guarantee for arbitrary operators.Validation: all 130 tests and 12 subtests in the triangular-operator module pass. Coverage includes vector/matrix and upper/lower gradchecks, a direct constant-RHS matrix-Hessian regression on CPU/CUDA, and independent dense comparisons for Cholesky-sample first and second derivatives. Against unchanged main, the two Cholesky cases and four constant-RHS subtests fail. Formatting, lint and diff checks pass.
Prepared with Codex; tests were exercised locally against unchanged upstream main.