Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiplying a batched low-rank-plus-diagonal covariance by per-model positive scalars raises
Boolean value of Tensor with more than one value is ambiguousin_mul_constant.Use
(other > 0).all(), matching the root operator's guard. All-positive batch factors keepLowRankRootAddedDiagLinearOperatorand its efficient solves. Any nonpositive factor still uses the existingAddedDiagLinearOperatorfallback.Regression tests compare broadcast scaling and root/diagonal/scale gradients with dense arithmetic for one and two batch dimensions, assert the specialized type is retained, and cover a zero-factor fallback.
Validation:
3.0e-6, float64 below5.6e-15. Ordinary matrix/scalar controls are byte-identical across sources.1.1e-3, final-parameter relative difference2.4e-6). This does not assert bitwise optimizer-state parity or predictive improvement.This fixes the specialized low-rank-plus-diagonal implementation; the block-operator scaling in #136 does not resolve it.