Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an unbatched low-rank-plus-diagonal operator,
inv_quad_logdet(y)validates an N-vector but then raiseslinalg.solve_triangular: The input tensor B must have at least 2 dimensions. The equivalenty[:, None]succeeds.Normalize the accepted vector to one RHS column after validating its length. This preserves the existing output shapes for both
reduce_inv_quadsettings and leaves matrix/batched inputs unchanged.Regression tests compare inverse quadratic forms, optional log determinants and root/diagonal/RHS gradients with an independent dense solve for both reduction settings. They also check exact vector/column equivalence and the existing invalid-length error.
Validation:
3.7e-6, float64 below4.7e-15. Matrix-input controls are byte-identical across sources.3.1e-4, final-parameter relative difference4.8e-6). This does not assert bitwise optimizer-state parity or predictive improvement.This concerns
LowRankRootAddedDiagLinearOperator; the diagonal-operator change in #140 does not resolve it.