Repository navigation
Fix low-rank solve examples in README - #146
Open
j45856021-dev wants to merge 1 commit into
Open
j45856021-dev wants to merge 1 commit into
j45856021-dev wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99.
Use a positive diagonal (
1 + torch.rand(...)) consistently in all three low-rank solve examples, following the maintainer guidance in the issue. The manual Woodbury comparison also needs an identity sized by the rank ofC, not its row count, and a column-shaped RHS fortorch.cholesky_solve; the result is squeezed back to the documented vector shape.This changes only
README.md, which is also the source for the corresponding Sphinx index section. No operator implementation changes.Validation
torch.linalg.solve. The original README produced 12 failing cases: non-positive-definite matrices, a rank/row size mismatch, and a one-dimensional Cholesky-solve RHS.test.operators.test_low_rank_root_added_diag_linear_operatorpass. Environment: Python 3.13.16, PyTorch 2.14.1, macOS arm64.-W --keep-goingsucceeds, and the three changed code blocks match the rendered HTML. Both baseline and patched builds emit the same 55 existing PythonRuntimeWarnings from the type-hint formatter inconf.py; neither build is warning-free.git diff --checkand the applicable README text checks pass.The 10-million-row example was exercised at 64 rows, not allocated in full. The full repository suite, minimum-version/GPU matrix and pre-commit orchestration were not run; applicable text checks were checked independently.
AI disclosure: Prepared and checked autonomously with GPT-6 Astra. No human review is claimed.