Fix #70: remove the dead missingDependencies() factory and the unreachable testbench ^10 range - #101
Open
corgab wants to merge 1 commit into
Open
Fix #70: remove the dead missingDependencies() factory and the unreachable testbench ^10 range#101corgab wants to merge 1 commit into
corgab wants to merge 1 commit into
Conversation
…chable testbench ^10 range PythonEnvironmentException::missingDependencies() was never called from src/; AetherInstallCommand reports missing Braket packages through console output instead, so the factory and its only test are removed. orchestra/testbench ^10.0 requires laravel/framework ^12 while this package requires illuminate/* ^13.0, so Composer could never select that branch. The constraint now states the one version that actually resolves. Closes #70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two leftovers that cost attention on every read without doing anything: an exception factory nobody calls and a Composer range Composer can never pick.
Plan
PythonEnvironmentException::missingDependencies()has no caller insrc/(only its own unit test references it) and thatAetherInstallCommandalready reports missing Braket packages through console output.orchestra/testbenchto^11.0, the only branch that resolves againstilluminate/* ^13.0.Changes
src/Exceptions/PythonEnvironmentException.php: removemissingDependencies().tests/Unit/Exceptions/ExceptionHierarchyTest.php: remove the test that only existed to exercise the dead factory.composer.json:orchestra/testbenchis now^11.0(testbench 10.x requireslaravel/framework ^12, which this package's^13.0requirement excludes).Tests
vendor/bin/pint --testpasses.vendor/bin/pest --compact: 790 tests, 1300 assertions, 1 skipped (was 791; the removed test is the difference).composer validatepasses on the new constraint.Closes #70
Generated by Claude Code